Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias variables block in the
Target
struct #1748Alias variables block in the
Target
struct #1748Changes from all commits
75f252e
43325fd
6d2f882
65f1c75
7db32fc
b899285
b023ba0
e24725d
460eeb9
00e5896
0813312
7c70179
39efb70
790731f
535f670
11dfdc0
870e419
2dea889
d07192f
fcdccb3
e7fd063
5b79747
ac60163
2c30cfa
483480f
727036b
acc4309
f194a5b
ad7503a
40f4d35
aac6687
4141f4e
cb8d6a9
578019b
176ced1
3d5c076
be0ad48
8575c47
46585bb
6bd7ad0
66cbb54
ba3f004
9d9c612
446463b
bfe9cc4
a64857e
42da1c9
d0aa493
4379d7f
e55df7b
1dd399f
75a571a
8cd2631
c69e6d9
2d62c0c
5f48b58
ab3dd7a
804d379
4c3facc
d9432e5
65ed301
e1a8e03
48af9d1
176bb4b
507b99d
f26027a
9689a79
c365fd4
3b06a94
ed55a23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyas-goenka Could we have an integration test for this as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do, see:
bundle/internal/schema/testdata/pass/direct_value_in_target.yml
in #1726. Do you mean more coverage?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointer. I was under the assumption the integration tests were merged before this one, which would imply there is no coverage for this case, but it's the other way around, so all good.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.