Alias variables block in the Target struct
#1748
Merged
+80
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
force-pushed
the
schema-overrides
branch
from
ec328d3 to
7137d22
Compare
shreyas-goenka
force-pushed
the
schema-overrides
branch
from
7137d22 to
c365fd4
Compare
pietern
reviewed
Sep 11, 2024
| // All values are valid for a variable value, be it primitive types | ||
| // like string/bool or complex ones like objects/arrays. Thus we override | ||
| // the schema to allow all valid JSON values. | ||
| {}, |
There was a problem hiding this comment.
@shreyas-goenka Could we have an integration test for this as well?
There was a problem hiding this comment.
We do, see: bundle/internal/schema/testdata/pass/direct_value_in_target.yml in #1726. Do you mean more coverage?
There was a problem hiding this comment.
Thanks for the pointer. I was under the assumption the integration tests were merged before this one, which would imply there is no coverage for this case, but it's the other way around, so all good.
andrewnester
added a commit
that referenced
this pull request
Sep 18, 2024
CLI: * Added listing cluster filtering for cluster lookups ([#1754](#1754)). Bundles: * Expand library globs relative to the sync root ([#1756](#1756)). * Fixed generated YAML missing 'default' for empty values ([#1765](#1765)). * Use periodic triggers in all templates ([#1739](#1739)). * Use the friendly name of service principals when shortening their name ([#1770](#1770)). * Fixed detecting full syntax variable override which includes type field ([#1775](#1775)). Internal: * Pass copy of `dyn.Path` to callback function ([#1747](#1747)). * Make bundle JSON schema modular with `$defs` ([#1700](#1700)). * Alias variables block in the `Target` struct ([#1748](#1748)). * Add end to end integration tests for bundle JSON schema ([#1726](#1726)). * Fix artifact upload integration tests ([#1767](#1767)). API Changes: * Added `databricks quality-monitors regenerate-dashboard` command. OpenAPI commit d05898328669a3f8ab0c2ecee37db2673d3ea3f7 (2024-09-04) Dependency updates: * Bump golang.org/x/term from 0.23.0 to 0.24.0 ([#1757](#1757)). * Bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 ([#1761](#1761)). * Bump golang.org/x/text from 0.17.0 to 0.18.0 ([#1759](#1759)). * Bump github.com/databricks/databricks-sdk-go from 0.45.0 to 0.46.0 ([#1760](#1760)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
Bundles: * Added listing cluster filtering for cluster lookups ([#1754](#1754)). * Expand library globs relative to the sync root ([#1756](#1756)). * Fixed generated YAML missing 'default' for empty values ([#1765](#1765)). * Use periodic triggers in all templates ([#1739](#1739)). * Use the friendly name of service principals when shortening their name ([#1770](#1770)). * Fixed detecting full syntax variable override which includes type field ([#1775](#1775)). Internal: * Pass copy of `dyn.Path` to callback function ([#1747](#1747)). * Make bundle JSON schema modular with `$defs` ([#1700](#1700)). * Alias variables block in the `Target` struct ([#1748](#1748)). * Add end to end integration tests for bundle JSON schema ([#1726](#1726)). * Fix artifact upload integration tests ([#1767](#1767)). API Changes: * Added `databricks quality-monitors regenerate-dashboard` command. OpenAPI commit d05898328669a3f8ab0c2ecee37db2673d3ea3f7 (2024-09-04) Dependency updates: * Bump golang.org/x/term from 0.23.0 to 0.24.0 ([#1757](#1757)). * Bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 ([#1761](#1761)). * Bump golang.org/x/text from 0.17.0 to 0.18.0 ([#1759](#1759)). * Bump github.com/databricks/databricks-sdk-go from 0.45.0 to 0.46.0 ([#1760](#1760)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR aliases and overrides the schema associated with the variables block in
targetto allow for directly specifying a variable value in the JSON schema (without an levels of nesting). This is needed because this direct value is resolved by dynamically parsing the configuration tree.cli/bundle/config/root.go
Line 424 in ca6332a
Tests
Existing unit tests.