-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end to end tests to validate the generated JSON schema #1534
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,7 +137,7 @@ func (m *resolveVariableReferences) Apply(ctx context.Context, b *bundle.Bundle) | |
normalized, _ := convert.Normalize(b.Config, root, convert.IncludeMissingFields) | ||
|
||
// If the pattern is nil, we resolve references in the entire configuration. | ||
root, err := dyn.MapByPattern(root, m.pattern, func(p dyn.Path, v dyn.Value) (dyn.Value, error) { | ||
root, err := dyn.MapByPattern(root, m.pattern, func(_ dyn.Path, v dyn.Value) (dyn.Value, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated. |
||
// Resolve variable references in all values. | ||
return dynvar.Resolve(v, func(path dyn.Path) (dyn.Value, error) { | ||
// Rewrite the shorthand path ${var.foo} into ${variables.foo.value}. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
bundle: | ||
name: variable reference int | ||
|
||
variables: | ||
my_var: | ||
description: does not matter | ||
default: 1234 | ||
|
||
resources: | ||
jobs: | ||
foo: | ||
name: def | ||
tasks: | ||
- task_key: abcd | ||
run_job_task: | ||
job_id: ${var.my_var} | ||
|
||
targets: | ||
staging: | ||
default: true | ||
variables: | ||
my_var: 7890 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
bundle: | ||
name: variable reference string | ||
|
||
variables: | ||
my_var: | ||
description: does not matter | ||
default: "hello" | ||
|
||
resources: | ||
jobs: | ||
foo: | ||
name: ${var.my_var} | ||
|
||
targets: | ||
staging: | ||
default: true | ||
variables: | ||
my_var: "world" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything under
bundle/tests
has accompanying Go tests. I'd like to keep it that way so that you know which tests may be affected by changes. If someone reuses these YAML files for tests it introduces coupling.Could you move this under
bundle/schema/testdata
?