Add end to end tests to validate the generated JSON schema #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
reviewed
Jul 10, 2024
| @@ -115,3 +115,8 @@ jobs: | |||
| run: | | |||
| go run main.go bundle schema > schema.json | |||
| ajv -s schema.json -d ./bundle/tests/basic/databricks.yml | |||
|
|
|||
| # Valid configuration should pass schema validation. | |||
| for file in ./bundle/tests/jsonschema/allowed/*.yml; do | |||
There was a problem hiding this comment.
Everything under bundle/tests has accompanying Go tests. I'd like to keep it that way so that you know which tests may be affected by changes. If someone reuses these YAML files for tests it introduces coupling.
Could you move this under bundle/schema/testdata?
| @@ -137,7 +137,7 @@ func (m *resolveVariableReferences) Apply(ctx context.Context, b *bundle.Bundle) | |||
| normalized, _ := convert.Normalize(b.Config, root, convert.IncludeMissingFields) | |||
|
|
|||
| // If the pattern is nil, we resolve references in the entire configuration. | |||
| root, err := dyn.MapByPattern(root, m.pattern, func(p dyn.Path, v dyn.Value) (dyn.Value, error) { | |||
| root, err := dyn.MapByPattern(root, m.pattern, func(_ dyn.Path, v dyn.Value) (dyn.Value, error) { | |||
|
Superseded by #1726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TODO: Also account for the case when
${resources...}is used as a run_job_task.Tests