Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warnings when conflicting configuration is specified #1506

Closed
wants to merge 1 commit into from

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jun 18, 2024

Depends on #1503

A warning mutator for when ineffective configuration pieces are specified.

Note: We do not give a warning when one of the conflicting value is nil. It already has a separate existing warning (#1329). If we wish to show conflict warnings for nil as well, we'll need to preserve nil values during normalization which is not the case today (code where we lose out on nil information during normalizaton:

return dyn.InvalidValue, diags.Append(nullWarning(dyn.KindString, src, path))
)

What does the warning look like?

Warning: Multiple values found for the same configuration bundle.name. Only the value from location resources.yml:2:9 will be used. Locations found: [resources.yml:2:9 databricks.yml:3:9]
  at bundle.name
  in resources.yml:2:9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant