-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track multiple locations associated with a dyn.Value
#1510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch file used:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…1520) ## Changes This PR makes two changes: 1. In #1510 we'll be adding multiple associated location metadata with a dyn.Value. The Go compiler does not allow comparing structs if they contain slice values (presumably due to multiple possible definitions for equality). In anticipation for adding a `[]dyn.Location` type field to `dyn.Value` this PR removes all direct comparisons of `dyn.Value` and instead relies on the kind. 2. Retain location metadata for values in convert.FromTyped. The change diff is exactly the same as #1523. It's been combined with this PR because they both depend on each other to prevent test failures (forming a test failure deadlock). Go patch used: ``` @@ var x expression @@ -x == dyn.InvalidValue +x.Kind() == dyn.KindInvalid @@ var x expression @@ -x != dyn.InvalidValue +x.Kind() != dyn.KindInvalid @@ var x expression @@ -x == dyn.NilValue +x.Kind() == dyn.KindNil @@ var x expression @@ -x != dyn.NilValue +x.Kind() != dyn.KindNil ``` ## Tests Unit tests and integration tests pass.
shreyas-goenka
commented
Jul 1, 2024
Once this is merged, I'll followup with the first use case for this: #1506 |
pietern
reviewed
Jul 1, 2024
pietern
changed the title
Track multiple locations associated with a dyn.Value
Track multiple locations associated with a Jul 2, 2024
dyn.Value
pietern
reviewed
Jul 2, 2024
pietern
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andrewnester Can you TAL as well?
// | ||
// - Merging primitive values means using the incoming value `b`. The location of the | ||
// incoming value is retained and the location of the existing value `a` is accumulated. | ||
// This is because the incoming value overwrites the existing value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clear, thanks.
andrewnester
approved these changes
Jul 16, 2024
andrewnester
added a commit
that referenced
this pull request
Jul 18, 2024
CLI: * [Fix] Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Use local Terraform state only when lineage match ([#1588](#1588)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Closed
andrewnester
added a commit
that referenced
this pull request
Jul 18, 2024
CLI: * Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). * Use local Terraform state only when lineage match ([#1588](#1588)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
CLI: * Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). * Use local Terraform state only when lineage match ([#1588](#1588)). * Add read-only mode for extension aware workspace filer ([#1609](#1609)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the location metadata associated with a
dyn.Value
to a slice of locations. This will allow us to keep track of location metadata across merges and overrides.The convention is to treat the first location in the slice as the primary location. Also, the semantics are the same as before if there's only one location associated with a value, that is:
Tests
Modifying existing merge unit tests. Other existing unit tests and integration tests pass.