Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GitHub PR template #814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a GitHub PR template #814

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34e41eb
Add a GitHub PR template
hristog Mar 29, 2021
e91b8bd
Merge remote-tracking branch 'dask/main' into add-pr-template
hristog Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
- [ ] Closes #xxxx
- [ ] Tests added / passed
- [ ] Passes `flake8`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opted to:

Would be happy to amend the PR accordingly, subject to expressed preferences for alternatives.

- [ ] Passes `black dask_ml`
- [ ] Passes `isort .`
- [ ] Passes `mypy dask_ml/metrics`
- [ ] Passes `mypy dask_ml/preprocessing`