Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub PR template #814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hristog
Copy link
Contributor

@hristog hristog commented Mar 28, 2021

This PR proposes the introduction of a PR template, following the same structure as those in dask and distributed.

@@ -0,0 +1,4 @@
- [ ] Closes #xxxx
- [ ] Tests added / passed
- [ ] Passes `black dask_ml` / `flake8 dask_ml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to add isort and mypy to this check too. At a certain point it might be worth pointing to ci/code_checks.sh or pre-commit instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to add isort and mypy to this check too.

I was waiting for the resolution of #813 first, before introducing an isort check here, but now that you've brought it up, I don't see why it couldn't be introduced at the current stage.
Thanks for reminding me about mypy - I'd completely forgotten about it.

At a certain point it might be worth pointing to ci/code_checks.sh or pre-commit instead

Do you mean verbally, or is there some related GitHub magic trick(s)?

@@ -0,0 +1,8 @@
- [ ] Closes #xxxx
- [ ] Tests added / passed
- [ ] Passes `flake8`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opted to:

Would be happy to amend the PR accordingly, subject to expressed preferences for alternatives.

@hristog
Copy link
Contributor Author

hristog commented Mar 29, 2021

Hmm the "CI / docs (pull_request)" failure is new:

Updating 'dask-ml-docs' env from conda env update...
  /usr/share/miniconda3/condabin/conda env update --name dask-ml-docs --file /tmp/environment-patched.yml
  Collecting package metadata (repodata.json): ...working... done
  Solving environment: ...working... failed
  Warning: 
  ResolvePackageNotFound: 
    - python[version='3.6.6.*,3.7.*']

  ResolvePackageNotFound: 
    - python[version='3.6.6.*,3.7.*']

It doesn't seem to me that it's related to the most recent commit pushed to this PR.

@hristog
Copy link
Contributor Author

hristog commented Mar 29, 2021

I can see the same failure in #813.

@jrbourbeau, could this by any chance be related to dask/distributed#4647 (comment)?

@jrbourbeau
Copy link
Member

Ah, thanks for pointing the documentation build errors out -- should be fixed by #815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants