Minimise race-conditions 2

dask · Sep 18, 2023 · 5b332f4 · 5b332f4
1 parent 244c96d
commit 5b332f4
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/dask_kubernetes/operator/controller/controller.py b/dask_kubernetes/operator/controller/controller.py
@@ -603,13 +603,17 @@ async def daskworkergroup_replica_update(
                     pending_workers.append(worker)
 
             if pending_workers:
-                logger.info(f"Pending worker deployments to delete: {pending_workers}")
+                deleted_deployments = []
                 for worker in pending_workers:
                     if await worker.ready():
                         continue
                     await worker.delete()
+                    deleted_deployments.append(worker)
+                logger.info(
+                    f"Deleted pending worker deployments: {deleted_deployments}"
+                )
 
-            n_workers = -workers_needed - len(pending_workers)
+            n_workers = -workers_needed - len(deleted_deployments)
             if n_workers > 0:
                 worker_ids = await retire_workers(
                     n_workers=n_workers,