Minimise race-conditions

dask · Sep 18, 2023 · 244c96d · 244c96d
1 parent 1990334
commit 244c96d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/dask_kubernetes/operator/controller/controller.py b/dask_kubernetes/operator/controller/controller.py
@@ -599,12 +599,14 @@ async def daskworkergroup_replica_update(
             for worker in current_workers:
                 if len(pending_workers) >= -workers_needed:
                     break
-                if await worker.ready():
+                if not await worker.ready():
                     pending_workers.append(worker)
 
             if pending_workers:
                 logger.info(f"Pending worker deployments to delete: {pending_workers}")
                 for worker in pending_workers:
+                    if await worker.ready():
+                        continue
                     await worker.delete()
 
             n_workers = -workers_needed - len(pending_workers)