Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use declarative setuptools #41

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Use declarative setuptools #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,23 @@ build-backend = "setuptools.build_meta"

[project]
name = "crick"
description="High performance approximate and streaming algorithms"
maintainers = [{name = "Jim Crist", email = "[email protected]"}]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Jim no longer has time/desire to maintain crick. @fjetter I see dask/dask and distributed both have Matt as the maintainers, do we want to add/change this as well for crick?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to keep this as is for now and fix the packaging without worrying about this too much. I'm fine changing this but I want Jim's ACK and frankly I don't know what else to put in here. We should probably setup an [email protected] email address if that doesn't exist yet (@jacobtomlinson does something like that exist?)

license = {text = "BSD-3-Clause"}
readme = "README.rst"
requires-python = ">=3.8"
dynamic = ["version"]

[project.urls]
Source = "https://github.com/dask/crick"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Source a valid option?
Maybe Home (just based from reading this https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#urls)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, I see it's used in dask/distributed.


[tool.setuptools]
include-package-data = true
zip-safe = false

[tool.setuptools.packages.find]
namespaces = false

[tool.versioneer]
VCS = "git"
style = "pep440"
Expand Down
12 changes: 0 additions & 12 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,7 @@ def generate_code(templates):
]

setup(
name="crick",
version=versioneer.get_version(),
cmdclass=versioneer.get_cmdclass(),
description="High performance approximate and streaming algorithms",
long_description=(
open("README.rst").read() if os.path.exists("README.rst") else ""
),
keywords="streaming approximate algorithms",
url="https://github.com/dask/crick",
author="Jim Crist",
author_email="[email protected]",
license="BSD",
packages=["crick", "crick.tests"],
ext_modules=cythonize(extensions),
zip_safe=False,
)
Loading