Use declarative setuptools #41
Conversation
| requires-python = ">=3.8" | ||
| dynamic = ["version"] | ||
|
|
||
| [project.urls] | ||
| Source = "https://github.com/dask/crick" |
There was a problem hiding this comment.
Is Source a valid option?
Maybe Home (just based from reading this https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#urls)
There was a problem hiding this comment.
Nvm, I see it's used in dask/distributed.
| @@ -10,9 +10,23 @@ build-backend = "setuptools.build_meta" | |||
|
|
|||
| [project] | |||
| name = "crick" | |||
| description="High performance approximate and streaming algorithms" | |||
| maintainers = [{name = "Jim Crist", email = "[email protected]"}] | |||
There was a problem hiding this comment.
I believe Jim no longer has time/desire to maintain crick. @fjetter I see dask/dask and distributed both have Matt as the maintainers, do we want to add/change this as well for crick?
There was a problem hiding this comment.
I suggest to keep this as is for now and fix the packaging without worrying about this too much. I'm fine changing this but I want Jim's ACK and frankly I don't know what else to put in here. We should probably setup an [email protected] email address if that doesn't exist yet (@jacobtomlinson does something like that exist?)
Haven't really touched the cython bits here, but this should resolve dask/distributed#8369