fix(dashmate): local network starting issues

[shumkov]

Issue being fixed or feature implemented

It appears we don't need to manage mock time for Core, which very complex and lead to multiple different issues. For example, when you restart the system, a local network doesn't work anymore. There is an issue with starting local network in CI. It supposed to be fixed too.

What was done?

• Removed mock time

How Has This Been Tested?

Run local network locally

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• New Features

  • Added a migration for configuration version 1.8.0 that removes the mediantime property from the core.miner options.
  • Updated the JSON schema to simplify the miner requirements by removing the mediantime property.

• Bug Fixes

  • Removed unnecessary time manipulation parameters from various functions, streamlining the logic for probe checks and quorum connections.

• Chores

  • Removed tasks related to mocking core node time during setup processes, simplifying task execution.

[coderabbitai]

Warning

Rate limit exceeded

@shumkov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between cb97363 and 873627f.

📒 Files selected for processing (1)

• packages/dashmate/configs/getConfigFileMigrationsFactory.js (1 hunks)

Walkthrough

This pull request introduces a series of modifications across multiple files in the dashmate package, primarily focusing on removing the mediantime property from various configuration and task management components. The changes streamline the configuration structure by eliminating the mediantime property from the miner configuration, updating JSON schemas, and removing associated time manipulation tasks. These modifications simplify the configuration management and remove previously used mock time bumping mechanisms.

Changes

File	Change Summary
packages/dashmate/configs/defaults/getBaseConfigFactory.js	Removed mediantime property from miner configuration
packages/dashmate/configs/getConfigFileMigrationsFactory.js	Added migration for version 1.8.0 to delete mediantime property from core.miner configuration
packages/dashmate/src/config/configJsonSchema.js	Removed mediantime property from miner object and updated required properties
packages/dashmate/src/core/quorum/waitForMasternodeProbes.js	Removed bumpMockTime parameter from functions and associated logic
packages/dashmate/src/core/quorum/waitForQuorumConnections.js	Removed bumpMockTime parameter from function signature
packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js	Removed task related to setting initial mock time
packages/dashmate/src/listr/tasks/setup/local/enableCoreQuorumsTaskFactory.js	Removed multiple ctx.bumpMockTime() calls
packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js	Reinstated core.miner.interval setting for seed node
packages/dashmate/src/listr/tasks/startGroupNodesTaskFactory.js	Removed task for mocking core node time

Possibly related PRs

• chore(dashmate): update Core to version 22 #2107: Updates getConfigFileMigrationsFactory.js to remove mediantime property
• feat: start network with latest version if genesis version not set #2206: Introduces migration for removing mediantime property in version 1.0.0-dev.2
• chore(dashmate)!: update Core to version 22 #2384: Updates Docker image version in getBaseConfigFactory.js

Suggested labels

dashmate

Suggested reviewers

• QuantumExplorer
• lklimek

Poem

🐰 A Rabbit's Ode to Configuration Cleanup 🕰️

Mediantime, oh mediantime, you're gone away
Configs now dance with a lighter sway
No more mock time to bump or adjust
Simplicity reigns, in code we trust!

Hop, hop, configuration clean! 🐾

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.