fix(dashmate): some group commands fail with mtime not found

[shumkov]

Issue being fixed or feature implemented

❯ dashmate group stop
[STARTED] Stop local nodes
[STARTED] Task without title.
[STARTED] Check node is running
[SUCCESS] Check node is running [0.3s]
[STARTED] Save core node time
[FAILED] There is no option with 'core.miner.mediantime' path
[FAILED] There is no option with 'core.miner.mediantime' path
[FAILED] There is no option with 'core.miner.mediantime' path

What was done?

• Removed the rest of mock time logic from the group reset and stop commands

How Has This Been Tested?

Running the stop and reset commands

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Bug Fixes
  • Removed the task for resetting dashmate's ephemeral data.
  • Removed the task for saving core node time.

These changes streamline the task execution process by eliminating specific tasks while maintaining the overall functionality and structure of the related processes.

[coderabbitai]

Walkthrough

The pull request removes specific tasks related to managing the core.miner.mediantime configuration in two task factory files within the Dashmate package. The changes eliminate the tasks responsible for saving and resetting the core node's median time, specifically in resetNodeTaskFactory.js and stopNodeTaskFactory.js. These modifications appear to be part of a broader configuration simplification or cleanup process, removing previously used time-related configuration management tasks.

Changes

File	Change Summary
packages/dashmate/src/listr/tasks/resetNodeTaskFactory.js	Removed task "Reset dashmate's ephemeral data" that set core.miner.mediantime to null
packages/dashmate/src/listr/tasks/stopNodeTaskFactory.js	Removed task "Save core node time" that retrieved and saved median time from blockchain

Possibly related PRs

• fix(dashmate): local network starting issues #2394: Addresses the removal of the mediantime property from the configuration, directly related to the current changes

Suggested reviewers

• QuantumExplorer
• lklimek
• pshenmic

Poem

🐰 Median time, farewell and adieu,
Tasks stripped away, configuration anew
No more saving, no more reset
Dashmate's rhythm now more direct
Code simplifies with each gentle hop! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01a5b7a and c55d25e.

📒 Files selected for processing (2)

• packages/dashmate/src/listr/tasks/resetNodeTaskFactory.js (0 hunks)
• packages/dashmate/src/listr/tasks/stopNodeTaskFactory.js (0 hunks)

💤 Files with no reviewable changes (2)

• packages/dashmate/src/listr/tasks/resetNodeTaskFactory.js
• packages/dashmate/src/listr/tasks/stopNodeTaskFactory.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.