Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prebuilt librocksdb in docker image #2318

Merged
merged 29 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
8fba694
ci: prebuild librocksdb in docker image
lklimek Nov 8, 2024
e056b9f
chore: fix dockerfile build logic
lklimek Nov 8, 2024
714d999
chore: move test image build to gh runners
lklimek Nov 8, 2024
35de1fa
chore: don't run build-rust-deps when not needed
lklimek Nov 8, 2024
c8871b5
chore: update rust-decimal to trigger workflow
lklimek Nov 8, 2024
efe95f0
chore: update rocsdb in drive-abci
lklimek Nov 8, 2024
cb28ec2
chore(dpp): fix some linter warn to trigger ci
lklimek Nov 8, 2024
242836c
chore: fix Dockerfile according to coderabbitai feedback
lklimek Nov 12, 2024
a8119ad
refactor(Dockerfile): put env vars into /root/env file that is copied…
lklimek Nov 12, 2024
d7c3342
build: update sccache in gha
lklimek Nov 12, 2024
ccd8426
chore: fix sccache
lklimek Nov 12, 2024
886a93d
chore: sccache not working correctly
lklimek Nov 12, 2024
6c98a9e
fix: build fails for some reason
lklimek Nov 12, 2024
5afd8fb
chore: minor cleanup
lklimek Nov 12, 2024
38f94fe
chore: sime fixes + install snappy
lklimek Nov 12, 2024
ecabc9e
chore: fix
lklimek Nov 12, 2024
07a0c46
chore: clang
lklimek Nov 12, 2024
bf2161c
chore: minor fixes
lklimek Nov 12, 2024
6740cb5
build: install snappy lib
lklimek Nov 13, 2024
939befa
Merge remote-tracking branch 'origin/v1.6-dev' into build/prebuild-ro…
lklimek Nov 13, 2024
19dc0f1
chore: self-review and some docs
lklimek Nov 13, 2024
54792fd
chore: replace /root/env with /etc/profile
lklimek Nov 13, 2024
c1abdb0
chore: revert some cargo.toml changes that are out of scope
lklimek Nov 13, 2024
f491026
chore: fix snappy in ubuntu x86-64
lklimek Nov 13, 2024
650103f
Revert "chore: replace /root/env with /etc/profile"
lklimek Nov 13, 2024
58ac034
build: move to github-hosted runners
lklimek Nov 13, 2024
cd55eaa
feat(Dockerfile): on amd64,. build rocksdb optimized for haswell cpu
lklimek Nov 13, 2024
9ec5437
Revert "build: move to github-hosted runners"
lklimek Nov 13, 2024
a1156e0
Merge remote-tracking branch 'origin/v1.6-dev' into build/prebuild-ro…
lklimek Nov 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/docker/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ runs:
SCCACHE_S3_KEY_PREFIX=${{ runner.os }}/sccache
AWS_ACCESS_KEY_ID=${{ inputs.aws_access_key_id }}
AWS_SECRET_ACCESS_KEY=${{ inputs.aws_secret_access_key }}
AWS_REGION=${{ inputs.region }}
cache-from: ${{ steps.layer_cache_settings.outputs.cache_from }}
cache-to: ${{ steps.layer_cache_settings.outputs.cache_to }}
outputs: type=image,name=${{ inputs.image_org }}/${{ inputs.image_name }},push-by-digest=${{ inputs.push_tags != 'true' }},name-canonical=true,push=true
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/rust/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ runs:
export PATH="${PATH}:${HOME}/.local/bin"

- name: Run sccache-cache
uses: mozilla-actions/[email protected].3
uses: mozilla-actions/[email protected].6
with:
version: "v0.7.1" # Must be the same as in Dockerfile
version: "v0.8.2" # Must be the same as in Dockerfile
if: inputs.cache == 'true'

- name: Hash ref_name
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/tests-build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ on:
jobs:
build-image:
name: Build ${{ inputs.name }} image
runs-on: ["self-hosted", "linux", "arm64", "ubuntu-platform"]
# runs-on: ["self-hosted", "linux", "arm64", "ubuntu-platform"]
runs-on: ubuntu-24.04
steps:
- name: Check out repo
uses: actions/checkout@v4
Expand All @@ -41,7 +42,7 @@ jobs:
image_name: ${{ inputs.image_name }}
image_org: ${{ secrets.AWS_ACCOUNT_ID }}.dkr.ecr.${{ secrets.AWS_REGION }}.amazonaws.com
target: ${{ inputs.target }}
platform: linux/arm64
platform: linux/amd64
lklimek marked this conversation as resolved.
Show resolved Hide resolved
push_tags: true
dockerhub_username: ${{ secrets.DOCKERHUB_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_TOKEN }}
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ name: Tests

on:
workflow_dispatch:
inputs:
rebuild-deps:
description: "Rebuild cached Rust dependencies"
required: false
default: "false"
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches:
Expand Down Expand Up @@ -44,11 +39,14 @@ jobs:
build-rust-deps:
name: Prebuild and cache some Rust dependencies
runs-on: ubuntu-24.04
needs:
- changes
# run only if any changes were detected, eg. changes job returned non-empty list
if: ${{ needs.changes.outputs.rs-packages != '[]' }}
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_REGION: ${{ secrets.AWS_REGION }}

steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
183 changes: 3 additions & 180 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading