fix: not all identities were being used to broadcast documents in strategy tests

packages/strategy-tests/src/lib.rs

@@ -42,7 +42,7 @@ use dpp::state_transition::data_contract_update_transition::methods::DataContrac
 use operations::{DataContractUpdateAction, DataContractUpdateOp};
 use platform_version::TryFromPlatformVersioned;
 use rand::prelude::StdRng;
-use rand::seq::SliceRandom;
+use rand::seq::{IteratorRandom, SliceRandom};
 use rand::Rng;
 use std::collections::{BTreeMap, BTreeSet, HashMap, HashSet};
 use bincode::{Decode, Encode};
@@ -569,7 +569,8 @@ impl Strategy {
                         document_type,
                         contract,
                     }) => {
-                        // Get the first 10 identities who are eligible to submit documents for this contract
+                        // Filter and collect eligible identities
+                        // Eligible identities have less than 24 documents in the mempool for this contract
                         let first_10_eligible_identities: Vec<Identity> = current_identities
                             .iter()
                             .filter(|identity| {
@@ -578,9 +579,8 @@ impl Strategy {
                                     .unwrap_or(&0)
                                     < &24u64
                             })
-                            .take(10)
                             .cloned()
-                            .collect();
+                            .choose_multiple(rng, 10);
 
                         if first_10_eligible_identities.len() == 0 {
                             tracing::warn!(