Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not all identities were being used to broadcast documents in strategy tests #1852

Merged
merged 17 commits into from
Jul 21, 2024
Merged

fix: not all identities were being used to broadcast documents in strategy tests #1852

merged 17 commits into from
Jul 21, 2024

Conversation

pauldelucia
Copy link
Member

Issue being fixed or feature implemented

Not all identities were being used for submitting documents in strategy tests

How Has This Been Tested?

Platform TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov requested changes May 22, 2024
View reviewed changes
packages/strategy-tests/src/lib.rs Outdated Show resolved Hide resolved
@pauldelucia pauldelucia changed the title fix: select random identities for strategy documents fix: not all identities were being used to broadcast documents in strategy tests May 22, 2024
shumkov
shumkov requested changes May 22, 2024
View reviewed changes
packages/strategy-tests/src/lib.rs Outdated Show resolved Hide resolved
shumkov
shumkov previously approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shumkov
shumkov requested changes May 25, 2024
View reviewed changes
packages/strategy-tests/src/lib.rs Outdated Show resolved Hide resolved
packages/strategy-tests/src/lib.rs Outdated Show resolved Hide resolved
shumkov
shumkov requested changes May 26, 2024
View reviewed changes
packages/strategy-tests/src/lib.rs Outdated Show resolved Hide resolved
shumkov
shumkov previously approved these changes Jun 11, 2024
View reviewed changes
shumkov
shumkov approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pauldelucia pauldelucia merged commit 9a177ff into v1.0-dev Jul 21, 2024
63 checks passed
@pauldelucia pauldelucia deleted the fix/select-random-identities-for-strategy-documents branch July 21, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldelucia @shumkov