chore(drive)!: don't use 0.0.0.0
as default listen IP
#2977
Annotations
1 error and 11 warnings
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/v0/mod.rs#L7
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/v0/mod.rs:7:5
|
7 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/mod.rs#L15
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/mod.rs:15:5
|
15 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/v0_methods.rs#L7
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/v0_methods.rs:7:5
|
7 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L305
warning: trait `platform_types::platform_state::v0::PlatformStateV0PrivateMethods` is more private than the item `platform_types::platform_state::v0::PlatformStateV0Methods`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:305:1
|
305 | pub trait PlatformStateV0Methods: PlatformStateV0PrivateMethods {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ trait `platform_types::platform_state::v0::PlatformStateV0Methods` is reachable at visibility `pub`
|
note: but trait `platform_types::platform_state::v0::PlatformStateV0PrivateMethods` is only usable at visibility `pub(platform_state)`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:294:1
|
294 | pub(super) trait PlatformStateV0PrivateMethods {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_bounds)]` on by default
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L339
warning: redundant closure
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:339:18
|
339 | .map(|version| Ok(version))
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L583
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:583:223
|
583 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L583
warning: useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:583:237
|
583 | ...to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash.to_string()).join(" | "),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.validator_sets.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs#L157
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs:157:13
|
157 | &platform_ref,
| ^^^^^^^^^^^^^ help: change this to: `platform_ref`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:10:1
|
10 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
This job succeeded
Loading