chore(drive)!: don't use 0.0.0.0
as default listen IP
#2977
tests.yml
on: pull_request
Build JS packages
/
Build JS
2m 24s
Matrix: Build Docker images
Determine changed packages
26s
Rust crates security audit
30s
JS dependency versions check
11s
JS NPM security audit
12s
JS code security audit
/
Run Code QL
2m 40s
Packages functional tests
/
Run functional tests
2m 13s
Matrix: Test Suite
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Waiting for pending jobs
Matrix: Rust packages
Annotations
1 error and 36 warnings
Tests
Error when evaluating 'strategy' for job 'js-packages'. .github/workflows/tests.yml (Line: 115, Col: 21): Matrix vector 'js-package' does not contain any values
|
Determine changed packages
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust crates security audit
The following actions uses Node.js version which is deprecated and will be forced to run on node20: rustsec/audit-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust crates security audit
4 warnings found!
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build JS packages / Build JS
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS code security audit / Run Code QL
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
Rust packages (drive-abci) / Linting
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
unused import: `crate::identity::IdentityPublicKey`:
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/v0/mod.rs#L7
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/v0/mod.rs:7:5
|
7 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `crate::identity::IdentityPublicKey`:
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/mod.rs#L15
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/methods/mod.rs:15:5
|
15 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::identity::IdentityPublicKey`:
packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/v0_methods.rs#L7
warning: unused import: `crate::identity::IdentityPublicKey`
--> packages/rs-dpp/src/state_transition/state_transitions/identity/identity_credit_withdrawal_transition/v0/v0_methods.rs:7:5
|
7 | use crate::identity::IdentityPublicKey;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
trait `platform_types::platform_state::v0::PlatformStateV0PrivateMethods` is more private than the item `platform_types::platform_state::v0::PlatformStateV0Methods`:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L305
warning: trait `platform_types::platform_state::v0::PlatformStateV0PrivateMethods` is more private than the item `platform_types::platform_state::v0::PlatformStateV0Methods`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:305:1
|
305 | pub trait PlatformStateV0Methods: PlatformStateV0PrivateMethods {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ trait `platform_types::platform_state::v0::PlatformStateV0Methods` is reachable at visibility `pub`
|
note: but trait `platform_types::platform_state::v0::PlatformStateV0PrivateMethods` is only usable at visibility `pub(platform_state)`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:294:1
|
294 | pub(super) trait PlatformStateV0PrivateMethods {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_bounds)]` on by default
|
redundant closure:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L339
warning: redundant closure
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:339:18
|
339 | .map(|version| Ok(version))
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Ok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
`to_string` applied to a type that implements `Display` in `format!` args:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L583
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:583:223
|
583 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L583
warning: useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:583:237
|
583 | ...to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash.to_string()).join(" | "),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.validator_sets.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs#L157
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/check_tx/v0/mod.rs:157:13
|
157 | &platform_ref,
| ^^^^^^^^^^^^^ help: change this to: `platform_ref`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
module has the same name as its containing module:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:10:1
|
10 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (drive-abci) / Check each feature
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Packages functional tests / Run functional tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Rust packages (drive-abci) / Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|