Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rust crates security audit

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rust crates security audit

5 warnings found!

Rust crates security audit

Unknown warning kind unsound found, please, file a bug

Rust crates security audit

Unknown warning kind unsound found, please, file a bug

Rust packages (dashpay-contract) / Unused dependencies

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rust packages (dashpay-contract) / Unused dependencies

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rust packages (dapi-grpc) / Unused dependencies

Rust packages (dpp) / Unused dependencies

Rust packages (drive) / Unused dependencies

Rust packages (dash-sdk) / Unused dependencies

Rust packages (dpns-contract) / Unused dependencies

Rust packages (json-schema-compatibility-validator) / Unused dependencies

Rust packages (drive-abci) / Unused dependencies

Rust packages (wasm-dpp) / Unused dependencies

Rust packages (rs-dapi-client) / Unused dependencies

Rust packages (withdrawals-contract) / Unused dependencies

Rust packages (masternode-reward-shares-contract) / Unused dependencies

Rust packages (dashpay-contract) / Linting

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rust packages (dashpay-contract) / Tests

Rust packages (dapi-grpc) / Tests

Rust packages (dapi-grpc) / Linting

Rust packages (dapi-grpc) / Check each feature

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Rust packages (dash-sdk) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6

warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5 | 6 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`: packages/rs-drive/src/drive/document/mod.rs#L42

warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters` --> packages/rs-drive/src/drive/document/mod.rs:42:5 | 42 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`: packages/rs-drive/src/drive/document/mod.rs#L43

warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods` --> packages/rs-drive/src/drive/document/mod.rs:43:5 | 43 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `dpp::data_contract::document_type::DocumentTypeRef`: packages/rs-drive/src/drive/document/mod.rs#L45

warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef` --> packages/rs-drive/src/drive/document/mod.rs:45:5 | 45 | use dpp::data_contract::document_type::DocumentTypeRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `dpp::document::DocumentV0Getters`: packages/rs-drive/src/drive/document/mod.rs#L48

warning: unused import: `dpp::document::DocumentV0Getters` --> packages/rs-drive/src/drive/document/mod.rs:48:5 | 48 | use dpp::document::DocumentV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `HashSet`: packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L3

warning: unused import: `HashSet` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:3:29 | 3 | collections::{BTreeMap, HashSet}, | ^^^^^^^

unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0`: packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L22

warning: unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:22:9 | 22 | identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `dpp::util::deserializer::ProtocolVersion`: packages/rs-drive/src/fee_pools/mod.rs#L52

warning: unused import: `dpp::util::deserializer::ProtocolVersion` --> packages/rs-drive/src/fee_pools/mod.rs:52:5 | 52 | use dpp::util::deserializer::ProtocolVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `serialization_traits::DocumentPlatformConversionMethodsV0`: packages/rs-drive/src/query/mod.rs#L24

warning: unused import: `serialization_traits::DocumentPlatformConversionMethodsV0` --> packages/rs-drive/src/query/mod.rs:24:13 | 24 | serialization_traits::DocumentPlatformConversionMethodsV0, Document, DocumentV0Getters, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `crate::drive::verify::RootHash`: packages/rs-drive/src/query/mod.rs#L40

warning: unused import: `crate::drive::verify::RootHash` --> packages/rs-drive/src/query/mod.rs:40:5 | 40 | use crate::drive::verify::RootHash; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Rust packages (dash-sdk) / Check each feature

Rust packages (dpns-contract) / Linting

Rust packages (dpns-contract) / Tests

Rust packages (dash-sdk) / Tests

Rust packages (drive) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6

unused import: `crate::consensus::basic::BasicError`: packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L1

warning: unused import: `crate::consensus::basic::BasicError` --> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:1:5 | 1 | use crate::consensus::basic::BasicError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `crate::consensus::ConsensusError`: packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L2

warning: unused import: `crate::consensus::ConsensusError` --> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:2:5 | 2 | use crate::consensus::ConsensusError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `IdentityPublicKey`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2

warning: unused import: `IdentityPublicKey` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:2:23 | 2 | use crate::identity::{IdentityPublicKey, IdentityV0, KeyType, Purpose, SecurityLevel}; | ^^^^^^^^^^^^^^^^^

unused import: `std::collections::BTreeMap`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7

warning: unused import: `std::collections::BTreeMap` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5 | 7 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^

very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10 | 44 | ) -> ( | __________^ 45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>, 46 | | Vec<(KeyID, Purpose)>, 47 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L174

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:174:10 | 174 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs#L34

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs:34:10 | 34 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs#L37

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs:37:10 | 37 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/query/conditions.rs#L467

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/query/conditions.rs:467:10 | 467 | ) -> Result<(BTreeMap<String, Self>, Option<Self>, Option<Self>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Rust packages (dpp) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6

unused import: `IdentityPublicKey`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2

unused import: `std::collections::BTreeMap`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7

warning: unused import: `std::collections::BTreeMap` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5 | 7 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^

very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/document_factory/v0/mod.rs#L215

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/document_factory/v0/mod.rs:215:24 | 215 | let documents: Vec<( | ________________________^ 216 | | DocumentTransitionActionType, 217 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 218 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L223

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:223:24 | 223 | let documents: Vec<( | ________________________^ 224 | | DocumentTransitionActionType, 225 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 226 | | )> = documents_iter.into_iter().collect(); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

module has the same name as its containing module: packages/rs-dpp/src/identity/mod.rs#L10

warning: module has the same name as its containing module --> packages/rs-dpp/src/identity/mod.rs:10:1 | 10 | mod identity; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

large size difference between variants: packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L28

warning: large size difference between variants --> packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:28:1 | 28 | / pub enum AssetLockProof { 29 | | Instant(#[bincode(with_serde)] InstantAssetLockProof), | | ----------------------------------------------------- the largest variant contains at least 640 bytes 30 | | Chain(#[bincode(with_serde)] ChainAssetLockProof), | | ------------------------------------------------- the second-largest variant contains at least 40 bytes 31 | | } | |_^ the entire enum is at least 640 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields to reduce the total size of the enum | 29 | Instant(#[bincode(with_serde)] Box<InstantAssetLockProof>), | ~~~~~~~~~~~~~~~~~~~~~~~~~~

module has the same name as its containing module: packages/rs-dpp/src/util/cbor_value/mod.rs#L11

warning: module has the same name as its containing module --> packages/rs-dpp/src/util/cbor_value/mod.rs:11:1 | 11 | mod cbor_value; | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception

module has the same name as its containing module: packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs#L1

warning: module has the same name as its containing module --> packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs:1:1 | 1 | pub mod json_schema_error; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception

you should consider adding a `Default` implementation for `JsonSchemaValidator`: packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs#L10

warning: you should consider adding a `Default` implementation for `JsonSchemaValidator` --> packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs:10:5 | 10 | / pub fn new() -> Self { 11 | | Self { 12 | | validator: RwLock::new(None), 13 | | } 14 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 9 + impl Default for JsonSchemaValidator { 10 + fn default() -> Self { 11 + Self::new() 12 + } 13 + } |

Rust packages (json-schema-compatibility-validator) / Linting

Rust packages (dpp) / Tests

Rust packages (json-schema-compatibility-validator) / Tests

Rust packages (masternode-reward-shares-contract) / Tests

Rust packages (masternode-reward-shares-contract) / Linting

Rust packages (dpp) / Check each feature

Rust packages (drive-abci) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6

unused import: `IdentityPublicKey`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2

unused import: `std::collections::BTreeMap`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7

warning: unused import: `std::collections::BTreeMap` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5 | 7 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `ValidatorSetV0Setters`: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_quorum_info/v0/mod.rs#L11

warning: unused import: `ValidatorSetV0Setters` --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_quorum_info/v0/mod.rs:11:44 | 11 | ValidatorSetV0, ValidatorSetV0Getters, ValidatorSetV0Setters, | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

unreachable pattern: packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs#L284

warning: unreachable pattern --> packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs:284:9 | 284 | _ => Err(Error::Execution(ExecutionError::CorruptedCodeExecution( | ^ | = note: `#[warn(unreachable_patterns)]` on by default

module has the same name as its containing module: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11

warning: module has the same name as its containing module --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1 | 11 | mod update_masternode_identities; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32 | 40 | raw_state_transitions: &Vec<Vec<u8>>, | ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs#L251

warning: this expression creates a reference which is immediately dereferenced by the compiler --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs:251:17 | 251 | &signable_bytes_hasher.hash_bytes().as_slice(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs:178:17 | 178 | &signable_bytes_hasher.hash_bytes().as_slice(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

`to_string` applied to a type that implements `Display` in `format!` args: packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L491

warning: `to_string` applied to a type that implements `Display` in `format!` args --> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:491:223 | 491 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash... | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Rust packages (rs-dapi-client) / Linting

Rust packages (rs-dapi-client) / Check each feature

Rust packages (wasm-dpp) / Linting

unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6

module has the same name as its containing module: packages/wasm-dpp/src/data_contract_factory/mod.rs#L1

warning: module has the same name as its containing module --> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1 | 1 | mod data_contract_factory; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

very complex type used. Consider factoring parts into `type` definitions: packages/wasm-dpp/src/document/factory.rs#L153

warning: very complex type used. Consider factoring parts into `type` definitions --> packages/wasm-dpp/src/document/factory.rs:153:24 | 153 | let documents: Vec<( | ________________________^ 154 | | DocumentTransitionActionType, 155 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 156 | | )> = documents_by_action | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

use of a fallible conversion when an infallible one could be used: packages/wasm-dpp/src/document/factory.rs#L322

warning: use of a fallible conversion when an infallible one could be used --> packages/wasm-dpp/src/document/factory.rs:322:27 | 322 | let documents_array = js_sys::Array::try_from(documents_with_action) | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `JsValue` to `Array` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default

you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`: packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs#L21

warning: you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm` --> packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs:21:5 | 21 | / pub fn new() -> Self { 22 | | Self { 23 | | inner: MissingStateTransitionTypeError::new(), 24 | | } 25 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 19 + impl Default for MissingStateTransitionTypeErrorWasm { 20 + fn default() -> Self { 21 + Self::new() 22 + } 23 + } |

casting to the same type is unnecessary (`u64` -> `u64`): packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs#L34

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs:34:9 | 34 | *self.inner.setting_identity_contract_nonce() as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*self.inner.setting_identity_contract_nonce()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`: packages/wasm-dpp/src/errors/value_error.rs#L29

warning: implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm` --> packages/wasm-dpp/src/errors/value_error.rs:29:5 | 29 | / pub fn to_string(&self) -> String { 30 | | format!("PlatformValueError: {}", self.message) 31 | | } | |_____^ | = help: implement trait `Display` for type `errors::value_error::PlatformValueErrorWasm` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string = note: `#[warn(clippy::inherent_to_string)]` on by default

module has the same name as its containing module: packages/wasm-dpp/src/identity/mod.rs#L30

warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/mod.rs:30:1 | 30 | mod identity; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception

module has the same name as its containing module: packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs#L4

warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs:4:1 | 4 | pub mod identity_create_transition; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception

called `unwrap` on `document_type_name` after checking its variant with `is_some`: packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs#L117

warning: called `unwrap` on `document_type_name` after checking its variant with `is_some` --> packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs:117:37 | 114 | let contract_bounds = if document_type_name.is_some() { | ------------------------------- help: try: `if let Some(..) = document_type_name` ... 117 | document_type_name: document_type_name.unwrap(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

Rust packages (rs-dapi-client) / Tests

Rust packages (drive) / Tests

Rust packages (wasm-dpp) / Tests

Rust packages (withdrawals-contract) / Linting

Rust packages (withdrawals-contract) / Tests

Build JS packages / Build JS

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

JS packages (@dashevo/dapi-grpc) / Linting

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

JS packages (@dashevo/dashpay-contract) / Linting

JS packages (@dashevo/dash-spv) / Linting

JS packages (@dashevo/dpns-contract) / Linting

JS packages (@dashevo/wallet-lib) / Linting

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L24

Unexpected unnamed function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L766

Unexpected unnamed async function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsReader.spec.js#L801

Unexpected unnamed async function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/plugins/Workers/TransactionsSyncWorker/TransactionsSyncWorker.spec.js#L881

Unexpected unnamed function

JS packages (@dashevo/wallet-lib) / Linting: packages/wallet-lib/src/test/mocks/dashcore/block.js#L33

Unexpected console statement

JS packages (@dashevo/dapi) / Linting

JS packages (@dashevo/masternode-reward-shares-contract) / Linting

Rust packages (drive-abci) / Check each feature

JS packages (@dashevo/dash-spv) / Tests

JS packages (@dashevo/dapi-grpc) / Tests

JS packages (@dashevo/dashpay-contract) / Tests

JS packages (@dashevo/masternode-reward-shares-contract) / Tests

JS packages (@dashevo/grpc-common) / Tests

JS packages (@dashevo/dpns-contract) / Tests

JS packages (@dashevo/wasm-dpp) / Linting

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/IdentityFacade.spec.js#L69

Unexpected console statement

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/IdentityUpdateTransition/validation/state/validateIdentityUpdateTransitionStateFactory.spec.js#L127

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L310

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L356

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/chain/validateChainAssetLockProofStructureFactory.spec.js#L381

Unexpected unnamed async function

JS packages (@dashevo/wasm-dpp) / Linting: packages/wasm-dpp/test/integration/identity/stateTransition/assetLockProof/fetchAssetLockTransactionOutputFactory.spec.js#L92

Unexpected unnamed async function

JS packages (@dashevo/platform-test-suite) / Linting

JS packages (@dashevo/dapi-client) / Tests

JS packages (@dashevo/withdrawals-contract) / Linting

JS packages (dash) / Linting

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L10

Dependency cycle via ./Platform:1

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L166

Assignment to function parameter 'options'

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Fetcher/Fetcher.ts#L143

Returning an awaited value that is not a promise is not allowed

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.spec.ts#L5

Using exported name 'Client' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5

Dependency cycle via ./Platform:10

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5

Using exported name 'Client' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8

Dependency cycle detected

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8

Using exported name 'createAssetLockTransaction' as identifier for default export

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L10

Dependency cycle detected

JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L11

Dependency cycle detected

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (DAPI, dapi, dapi) / Build DAPI image

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

JS packages (@dashevo/grpc-common) / Linting

JS packages (@dashevo/dapi) / Tests

JS packages (dashmate) / Linting

JS packages (@dashevo/wasm-dpp) / Tests

JS packages (dashmate) / Tests

JS packages (@dashevo/withdrawals-contract) / Tests

Build Docker images (Drive, drive, drive-abci) / Build Drive image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Drive, drive, drive-abci) / Build Drive image

Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead

Build Docker images (Drive, drive, drive-abci) / Build Drive image

JS packages (@dashevo/wallet-lib) / Tests

JS packages (@dashevo/dapi-client) / Linting

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L8

Missing JSDoc @Property "network" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L38

Missing JSDoc @param "options" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L39

Missing JSDoc @param "createHistoricalSyncStream" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L40

Missing JSDoc @param "createContinuousSyncStream" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L63

Missing JSDoc @param "blockHeadersReader" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L71

Missing JSDoc @param "spvChain" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L107

Missing JSDoc @param "headers" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L107

Missing JSDoc @param "headers" type

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108

Missing JSDoc @param "firstHeaderHeight" description

JS packages (@dashevo/dapi-client) / Linting: packages/js-dapi-client/lib/BlockHeadersProvider/BlockHeadersProvider.js#L108

Missing JSDoc @param "firstHeaderHeight" type

JS code security audit / Run Code QL

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

JS code security audit / Run Code QL

CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

JS packages (dash) / Tests

Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image

Runner ubuntu-platform-arm64-4x_i-0753533731ec188fa did not respond to a cancelation request with 00:05:00.

Rust packages (drive-abci) / Tests

Runner ubuntu-platform-arm64-4x_i-0c01bfae625e60627 did not respond to a cancelation request with 00:05:00.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(drive)!: verify instant lock signatures with Drive #2584

Summary

perf(drive)!: verify instant lock signatures with Drive #2584

Jobs

Run details

tests.yml

Annotations