perf(drive)!: verify instant lock signatures with Drive #1875

shumkov · 2024-06-05T17:45:41Z

Issue being fixed or feature implemented

Core RPC was never designed for public access and according to our tests is a weak point in the system. Under the load, instant lock signature verification takes seconds. Since users can trigger signature verification via invalid IdentityCreateTransition for free, this open a DoS attack vector.

What was done?

Own implementation of Instant Lock signature verification for InstantAssetLockProof without calling Core RPC
Introduced support for DIP24 rotating quorums
Base config network in dashmate changed to mainnet
Updated quorums configuration for local, testnet and mainnet
Added missing logging for invalid asset lock based state transitions
Updated invalid signature error for better verbosity
Fixed internal error if chain lock signature is not valid

How Has This Been Tested?

Unit tests skip instant lock signature verification with disable_instant_lock_signature_verification test config option.
Implemented Instant Lock quorums and signing in strategy tests
Updated run_chain_top_up_identities to use InstantLock singing with DIP24 rotating quorums
Updated run_chain_insert_one_new_identity_per_block_with_block_signing to use InstantLock singing with DIP8 classic quorums
With test suite against local network
With test suite against a devnet

Breaking Changes

InstantAssetLockProof might give different validation results, since our implementation supports only recent signatures, compared with Core RPC. This means the previous blockchain data might become invalid.

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

I have assigned this pull request to a milestone

...ci/src/execution/validation/state_transition/common/asset_lock/proof/validate/instant/mod.rs

packages/rs-drive-abci/src/execution/platform_events/core_chain_lock/choose_quorum/mod.rs

...drive-abci/src/execution/platform_events/core_chain_lock/verify_chain_lock_locally/v0/mod.rs

packages/dashmate/src/config/configJsonSchema.js

packages/rs-drive-abci/src/mimic/test_quorum.rs

.../rs-drive-abci/src/execution/platform_events/core_based_updates/update_quorum_info/v0/mod.rs

...drive-abci/src/execution/platform_events/core_chain_lock/verify_chain_lock_locally/v0/mod.rs

packages/rs-drive-abci/src/execution/platform_events/mod.rs

...ci/src/execution/validation/state_transition/common/asset_lock/proof/validate/instant/mod.rs

…o perf/drve/validate-is-locks

packages/rs-drive-abci/src/mimic/mod.rs

QuantumExplorer · 2024-06-23T09:19:40Z

.../rs-drive-abci/src/execution/platform_events/core_based_updates/update_quorum_info/v0/mod.rs

+        self.update_quorums(
+            QuorumSetType::InstantLock(instant_lock_quorum_type),
+            block_platform_state,
+            platform_state,
+            &extended_quorum_list,
+            is_validator_set_updated,
+            core_block_height,
+        )?;


I would do this only if instant_lock_quorum_type is different to chain_lock_quorum_type right?

QuantumExplorer · 2024-06-23T09:19:42Z

.../rs-drive-abci/src/execution/platform_events/core_based_updates/update_quorum_info/v0/mod.rs


-use crate::platform_types::validator_set::v0::{ValidatorSetV0, ValidatorSetV0Getters};
+use crate::platform_types::validator_set::v0::{
+    ValidatorSetV0, ValidatorSetV0Getters, ValidatorSetV0Setters,


...drive-abci/src/execution/platform_events/core_chain_lock/verify_chain_lock_locally/v0/mod.rs

…type

shumkov · 2024-06-23T12:13:35Z

Agreed with @QuantumExplorer that I will merge this PR and he will do a post review of the recent two changes later.

shumkov added 18 commits May 31, 2024 13:00

refactor: encapsulate chain lock validation quorum logic to be reused

85f2233

feat: introduce CoreQuorumSet

731673a

feat: verify recent instant lock signatures locally

6289886

feat: update instant lock quorums

10b982f

test: mock instant lock verification

ec321d3

test: implement instant lock signing

a3423f9

fix: return error if signature is not valid

dd3165e

docs: add todo for non-determinism issue

0c3425d

fix: non-deterministic quorum index is used

98a9e60

chore: log state transition validation result for asset lock based STs

eb43aa7

docs: add todo to have more verbose error

9102d0f

refactor: cleanup quorum set

0c6b1c6

fix: invalid selection logic for rotating quorums

ef8a001

test: fix instant lock signing logic in strategy tests

e14f9b7

chore(dashmate): update with new configuration

8842a22

chore(dashmate): add missing rotation option and correct llmq type

3260d80

docs: add todo for a bug

3462a77

chore: enhance logging for IS lock signature verification

d88fda3

shumkov marked this pull request as ready for review June 7, 2024 07:42

shumkov requested a review from QuantumExplorer as a code owner June 7, 2024 07:42

chore: kick off CI

29b2642

shumkov changed the title ~~perf(drive): verify instant lock signatures with Drive~~ perf(drive): verify instant lock signatures with Drive [WIP] Jun 7, 2024

shumkov changed the base branch from refactor/validating-quorums to v1.0-dev June 7, 2024 07:43

chore: kick off CI

fc39b72

shumkov commented Jun 7, 2024

View reviewed changes

...ci/src/execution/validation/state_transition/common/asset_lock/proof/validate/instant/mod.rs Show resolved Hide resolved

shumkov added 5 commits June 7, 2024 14:58

style: remove unused import

dc27176

chore: rephrase invalid signature error

7ddb81c

chore: remove unused trait implementation

fd1f994

chore: versioning for CoreQuorumSet

96360ff

chore: bump version to 1.0.0-pr.1875.1

93a604c

shumkov changed the title ~~perf(drive): verify instant lock signatures with Drive~~ perf(drive)!: verify instant lock signatures with Drive Jun 14, 2024

fix: non-deterministic quorum index

998b963

shumkov commented Jun 14, 2024

View reviewed changes

packages/rs-drive-abci/src/execution/platform_events/core_chain_lock/choose_quorum/mod.rs Show resolved Hide resolved

shumkov commented Jun 14, 2024

View reviewed changes

...drive-abci/src/execution/platform_events/core_chain_lock/verify_chain_lock_locally/v0/mod.rs Show resolved Hide resolved

shumkov added this to the v1.0.0 milestone Jun 14, 2024

QuantumExplorer requested changes Jun 18, 2024

View reviewed changes

shumkov added 18 commits June 18, 2024 21:51

style: unused import

016afc3

revert: remove non-determinism fix

3c71b37

refactor: rename select_quorums

fc51742

refactor: core_instant_lock -> core_instant_send_lock

7b1c6e7

chore: exclude the testing config for production

b9f765a

refactor: CoreQuorumSet to VerificationQuorumSet

2a47154

refactoring: more renamings

e2b551f

fix: outdated name

654b67e

fix: commit signature verification is disabled by default

e5a1114

revert: quorum index update

828bf7e

fix: block is not signing by default

0684d6c

chore: kick off CI

53e84c6

ci: show Rust formatting output

5856674

ci: improve formatting output

7dc94a6

Merge branch 'v1.0-dev' into perf/drve/validate-is-locks

496eda5

ci: fix formatting task

7378e31

Merge remote-tracking branch 'origin/perf/drve/validate-is-locks' int…

93eb706

…o perf/drve/validate-is-locks

style: fix formatting

a328355

QuantumExplorer requested changes Jun 23, 2024

View reviewed changes

shumkov added 2 commits June 23, 2024 17:58

perf: reuse chain lock quorums for instant lock if they are the same …

4f8f94a

…type

ci: install Rust 1.76 as default toolchain

29fb68b

shumkov merged commit a89d854 into v1.0-dev Jun 23, 2024
119 checks passed

shumkov deleted the perf/drve/validate-is-locks branch June 23, 2024 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(drive)!: verify instant lock signatures with Drive #1875

perf(drive)!: verify instant lock signatures with Drive #1875

shumkov commented Jun 5, 2024 •

edited

Loading

QuantumExplorer Jun 23, 2024

shumkov Jun 23, 2024

QuantumExplorer Jun 23, 2024

shumkov Jun 23, 2024

shumkov commented Jun 23, 2024

perf(drive)!: verify instant lock signatures with Drive #1875

perf(drive)!: verify instant lock signatures with Drive #1875

Conversation

shumkov commented Jun 5, 2024 • edited Loading

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

QuantumExplorer Jun 23, 2024

Choose a reason for hiding this comment

shumkov Jun 23, 2024

Choose a reason for hiding this comment

QuantumExplorer Jun 23, 2024

Choose a reason for hiding this comment

shumkov Jun 23, 2024

Choose a reason for hiding this comment

shumkov commented Jun 23, 2024

shumkov commented Jun 5, 2024 •

edited

Loading