Skip to content

chore(drive): improve withdrawal logging #3994

chore(drive): improve withdrawal logging

chore(drive): improve withdrawal logging #3994

Triggered via pull request October 3, 2024 11:58
Status Failure
Total duration 35m 0s
Artifacts

tests.yml

on: pull_request
Build JS packages  /  Build JS
2m 27s
Build JS packages / Build JS
Matrix: Build Docker images
Determine changed packages
17s
Determine changed packages
Rust crates security audit
28s
Rust crates security audit
JS dependency versions check
13s
JS dependency versions check
JS NPM security audit
12s
JS NPM security audit
JS code security audit  /  Run Code QL
2m 25s
JS code security audit / Run Code QL
Packages functional tests  /  Run functional tests
3m 5s
Packages functional tests / Run functional tests
Matrix: Test Suite
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Waiting for pending jobs
Matrix: Rust packages
Fit to window
Zoom out
Zoom in

Annotations

1 error and 42 warnings
Tests
Error when evaluating 'strategy' for job 'js-packages'. .github/workflows/tests.yml (Line: 115, Col: 21): Matrix vector 'js-package' does not contain any values
Build JS packages / Build JS
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build JS packages / Build JS
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Drive, drive, drive-abci) / Build Drive image
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/github-script@v6. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Determine changed packages
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, dorny/paths-filter@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust crates security audit
The following actions use a deprecated Node.js version and will be forced to run on node20: rustsec/audit-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust crates security audit
6 warnings found!
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Rust packages (drive-abci) / Formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust packages (drive-abci) / Unused dependencies
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (drive-abci) / Unused dependencies
The following actions use a deprecated Node.js version and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Packages functional tests / Run functional tests
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
JS code security audit / Run Code QL
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust packages (drive-abci) / Linting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust packages (drive-abci) / Linting
The following actions use a deprecated Node.js version and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
field `unversioned` is never read: packages/rs-platform-serialization-derive/src/attribute.rs#L8
warning: field `unversioned` is never read --> packages/rs-platform-serialization-derive/src/attribute.rs:8:9 | 5 | pub struct ContainerAttributes { | ------------------- field in this struct ... 8 | pub unversioned: bool, | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
field `platform_version_path_bounds` is never read: packages/rs-platform-serialization-derive/src/attribute.rs#L114
warning: field `platform_version_path_bounds` is never read --> packages/rs-platform-serialization-derive/src/attribute.rs:114:9 | 111 | pub struct FieldAttributes { | --------------- field in this struct ... 114 | pub platform_version_path_bounds: String, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `std::fmt`: packages/rs-dpp/src/core_types/validator/v0/mod.rs#L2
warning: unused import: `std::fmt` --> packages/rs-dpp/src/core_types/validator/v0/mod.rs:2:5 | 2 | use std::fmt; | ^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `Display`: packages/rs-dpp/src/core_types/validator/v0/mod.rs#L3
warning: unused import: `Display` --> packages/rs-dpp/src/core_types/validator/v0/mod.rs:3:23 | 3 | use std::fmt::{Debug, Display, Formatter}; | ^^^^^^^
unused variable: `st`: packages/rs-dpp/src/state_transition/mod.rs#L155
warning: unused variable: `st` --> packages/rs-dpp/src/state_transition/mod.rs:155:45 | 155 | StateTransition::IdentityCreate(st) => None, | ^^ help: if this is intentional, prefix it with an underscore: `_st` ... 404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose) | ------------------------------------------------------------------------------ in this macro invocation | = note: `#[warn(unused_variables)]` on by default = note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
unused variable: `st`: packages/rs-dpp/src/state_transition/mod.rs#L156
warning: unused variable: `st` --> packages/rs-dpp/src/state_transition/mod.rs:156:44 | 156 | StateTransition::IdentityTopUp(st) => None, | ^^ help: if this is intentional, prefix it with an underscore: `_st` ... 404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose) | ------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
unused imports: `get_withdrawal_transactions_broadcasted_path` and `get_withdrawal_transactions_queue_path`: packages/rs-drive/src/util/batch/drive_op_batch/withdrawals.rs#L4
warning: unused imports: `get_withdrawal_transactions_broadcasted_path` and `get_withdrawal_transactions_queue_path` --> packages/rs-drive/src/util/batch/drive_op_batch/withdrawals.rs:4:35 | 4 | get_withdrawal_root_path_vec, get_withdrawal_transactions_broadcasted_path, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 5 | get_withdrawal_transactions_broadcasted_path_vec, get_withdrawal_transactions_queue_path, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
this `else { if .. }` block can be collapsed: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L268
warning: this `else { if .. }` block can be collapsed --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:268:24 | 268 | } else { | ________________________^ 269 | | if let Some((_, found_old_key)) = identity_to_enable_old_keys 270 | | .iter() 271 | | .find(|(_, key)| key.purpose() == Purpose::TRANSFER) ... | 282 | | } 283 | | }; | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 268 ~ } else if let Some((_, found_old_key)) = identity_to_enable_old_keys 269 + .iter() 270 + .find(|(_, key)| key.purpose() == Purpose::TRANSFER) 271 + { 272 + Some(found_old_key.data().to_vec().try_into().map_err(|_| { 273 + Error::Execution(ExecutionError::CorruptedDriveResponse( 274 + "old payout address should be 20 bytes".to_string(), 275 + )) 276 + })?) 277 + } else { 278 + // finally we just use the old masternode payout address 279 + // we need to use the old pub_key_operator 280 + old_masternode.state.operator_payout_address 281 ~ }; |
taken reference of right operand: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L323
warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:323:42 | 323 | .find(|(_, key)| key.data().as_slice() == &new_payout_address) | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------- | | | help: use the right value directly: `new_payout_address` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
taken reference of right operand: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs#L347
warning: taken reference of right operand --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/update_operator_identity/v0/mod.rs:347:42 | 347 | .find(|(_, key)| key.data().as_slice() == &new_platform_node_id) | ^^^^^^^^^^^^^^^^^^^^^^^^^--------------------- | | | help: use the right value directly: `new_platform_node_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
Rust packages (drive-abci) / Check each feature
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust packages (drive-abci) / Check each feature
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
The following actions use a deprecated Node.js version and will be forced to run on node20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust packages (drive-abci) / Tests
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rust packages (drive-abci) / Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/