[WIP] MAINT: remove usage of --no-as-needed ld flag
#1007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanedsnyder
force-pushed
the
snyder/remove-no-as-needed
branch
from
6d8ac4c to
d0b58a5
Compare
Theoretically, this shouldn't be needed if we aren't relying on weak symobls in the Darshan library.
shanedsnyder
force-pushed
the
snyder/remove-no-as-needed
branch
from
d0b58a5 to
3468b0f
Compare
|
Eh, nevermind. We have a test case for a scenario that shows this flag is probably still needed. If an application doesn't make calls to functions Darshan wraps, but instead links to a library that does so, then Darshan is not linked in if this flag isn't used. I'll keep the flag and open additional PRs to update documentation to explain this and to add a test case to make sure we don't break this going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically, this shouldn't be needed if we aren't relying on weak symobls in the Darshan library.