Skip to content

Commit

Permalink
remove usage of --no-as-needed ld flag
Browse files Browse the repository at this point in the history
Theoretically, this shouldn't be needed if we aren't relying on
weak symobls in the Darshan library.
  • Loading branch information
shanedsnyder committed Sep 3, 2024
1 parent 4eb4a3a commit 6d8ac4c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions darshan-runtime/darshan-config.in
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ POST_LD_FLAGS="-L$DARSHAN_LIB_PATH -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ -lz -lrt
# NOTE:
# - when dynamic linking there is no need for wrapping options, we simply
# need to get the darshan symbol definitions early enough in the link
# order. We also set no-as-needed for linkers that may not identify
DYN_LD_FLAGS="-L$DARSHAN_LIB_PATH $DARSHAN_LD_FLAGS -Wl,-rpath=$DARSHAN_LIB_PATH -Wl,-no-as-needed -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ @DARSHAN_HDF5_LD_FLAGS@"
# order.
DYN_LD_FLAGS="-L$DARSHAN_LIB_PATH $DARSHAN_LD_FLAGS -Wl,-rpath=$DARSHAN_LIB_PATH -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ @DARSHAN_HDF5_LD_FLAGS@"

# NOTE:
# - construct complete list of log path options, separated by commas.
Expand Down
2 changes: 1 addition & 1 deletion darshan-runtime/pkgconfig/darshan-runtime.pc.in
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ darshan_libdir= -L${darshan_prefix}/lib
darshan_linkopts="-Wl,@${darshan_share}/ld-opts/darshan-ld-opts"

Cflags:
Libs: ${darshan_libdir} -Wl,-rpath=${darshan_prefix}/lib -Wl,-no-as-needed -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ @DARSHAN_HDF5_LD_FLAGS@ @with_papi@
Libs: ${darshan_libdir} -Wl,-rpath=${darshan_prefix}/lib -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ @DARSHAN_HDF5_LD_FLAGS@ @with_papi@
Libs.private: ${darshan_linkopts} ${darshan_libdir} -ldarshan @DARSHAN_LUSTRE_LD_FLAGS@ -lz -lrt -lpthread @with_papi@

0 comments on commit 6d8ac4c

Please sign in to comment.