Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run onnxsim python version in docker #282

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+17 −1
Open

Run onnxsim python version in docker #282

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9ea59a
Create Dockerfile
boltomli May 4, 2023
eadd6f2
Update README.md
boltomli May 4, 2023
d044b5e
Update Dockerfile
boltomli May 4, 2023
269f333
Run onnxsim -h in doc
boltomli May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
FROM python:3.10

RUN pip install -U onnxsim onnx onnxruntime
RUN pip install -U torch torchaudio torchvision -i https://download.pytorch.org/whl/cpu

RUN pip install -U pytest
WORKDIR /app
COPY tests/ tests/

ENTRYPOINT ["onnxsim"]
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ We have published ONNX Simplifier on [convertmodel.com](https://www.convertmodel

### Python version


```
pip3 install -U pip && pip3 install onnxsim
```
Expand All @@ -65,6 +64,13 @@ For more advanced features, try the following command for help message
onnxsim -h
```

Or run in docker

```
docker build -t onnx-simp .
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer 'onnxsim' :)

docker run --rm -it --entrypoint pytest onnx-simp
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use case of entry point "pytest"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure it would work properly. There are 3 failures so far (expected, as described in comments).

```

## Demonstration

An overall comparison between
Expand Down