Run onnxsim python version in docker #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daquexian
reviewed
May 4, 2023
README.md
Outdated
| Or run in docker | ||
|
|
||
| ``` | ||
| docker build -t onnx-simp . |
README.md
Outdated
|
|
||
| ``` | ||
| docker build -t onnx-simp . | ||
| docker run --rm -it --entrypoint pytest onnx-simp |
There was a problem hiding this comment.
what is the use case of entry point "pytest"?
There was a problem hiding this comment.
Just make sure it would work properly. There are 3 failures so far (expected, as described in comments).
It would be convenient to run on most OS without having to prepare the environment, especially when onnxruntime/pytorch dependencies would be different/hard to install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.