stylix: add background image scaling option #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #102 |
danth
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
I think fill is what most people would expect as the default. This list of options seems to be fairly common across different wallpaper programs, too.
This will need to be followed up by setting the option for more programs, and perhaps documenting what each scaling mode does - but it looks good to merge as a starting point.
danth
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds option for which type of scaling the background image should get
currently this only applied sway, but should probably be applied to the other WM/DE also supported in stylix, if someone knows how to configure it for the rest of them i'd appreciate the help
i set the default to be fill, the one the previous option used in sway by stylix, not sure if this should be the right default, as it seems some of the other WM/DEs have different default configs (eg gnome with zoom).
also not sure if "scaling mode" is the right term for this, it was what the sway man pages used.