-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: clean up fromOs
#407
Conversation
Regarding my two comments above, the easiest solution would be to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This now respects I doubt anyone was actually using I think this is ready to merge :) |
A common question/issue is that the fallback default value for
stylix.image
isnull
, which is not a path or package. This produces a type error when it should simply state that the option has not been set.This PR removes the
fromOs
function, and replaces it with a module which copies listed settings.mkDefault
, again to match previous behaviour.Fixes #406
Fixes #345