Patch entity_reference_revisions to break loop when updating event #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperg
force-pushed
the
avoid-memory-errors
branch
2 times, most recently
from
ced5303 to
dd4e0d7
Compare
We see PHP running out of memory when running a deploy hook, dpl_update_deploy_field_relevant_ticket_manager(), on a specific site, for a specific eventseries. It turns out this event series has instances where each instance has a paragraph which references other instances within the series. This creates a circular dependency. To break this we patch drupal/entity_reference_revisions. drupal/entity_reference_revisions is currently an implicit dependency through drupal/paragraphs. To avoid it moving without our explicit consent and patches thus not applying we add drupal/entity_reference_revisions as an explicit dependency. We use the same version as is currently used within the project.
kasperg
force-pushed
the
avoid-memory-errors
branch
from
dd4e0d7 to
234c2d4
Compare
rasben
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-74
Description
We see PHP running out of memory when running a deploy hook,
dpl_update_deploy_field_relevant_ticket_manager(), on a specific site, for a specific eventseries.It turns out this event series has instances where each instance has a paragraph which references other instances within the series. This creates a circular dependency.
To break this we patch
drupal/entity_reference_revisions.drupal/entity_reference_revisionsis currently an implicit dependency throughdrupal/paragraphs. To avoid it moving without our explicit consent and patches thus not applying we adddrupal/entity_reference_revisionsas an explicit dependency. We use the same version as is currently used within the project.Additional comments or questions
I can recreate the problem without this change using a backup from the failing site. With this change the problem no longer occurs.