Skip to content

Commit

Permalink
Patch entity_reference_revisions to break loop when updating event
Browse files Browse the repository at this point in the history
We see PHP running out of memory when running a deploy hook,
dpl_update_deploy_field_relevant_ticket_manager(), on a specific site,
for a specific eventseries.

It turns out this event series has instances where each instance has
a paragraph which references other instances within the series.
This creates a circular dependency.

To break this we patch drupal/entity_reference_revisions.

drupal/entity_reference_revisions is currently an implicit dependency
through drupal/paragraphs. To avoid it moving without our explicit
consent and patches thus not applying we add
drupal/entity_reference_revisions as an explicit dependency. We use
the same version as is currently used within the project.
  • Loading branch information
kasperg committed Oct 3, 2024
1 parent 11fa516 commit dd4e0d7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
"drupal/dynamic_entity_reference": "^3.1",
"drupal/editor_advanced_link": "^2.2",
"drupal/entity_clone_template": "^2.0",
"drupal/entity_reference_revisions": "^1.11.0",
"drupal/enum_field": "^1.0",
"drupal/facets": "^2.0",
"drupal/field_group": "^3.4",
Expand Down Expand Up @@ -316,6 +317,9 @@
"drupal/entity_clone_template": {
"3424597: Fix error when creating entity of type without templates": "https://git.drupalcode.org/project/entity_clone_template/-/commit/ad4964dd51f7f5e814111fcb73e6e472eefccf5c.patch"
},
"drupal/entity_reference_revisions": {
"3039442: Circular dependencies in EntityReferenceRevisionsFieldItemList::hasAffectingChanges()": "https://www.drupal.org/files/issues/2023-11-20/entity_reference_revisions-fix_infinite_loop-3039442-8.patch"
},
"drupal/field_inheritance": {
"3454350: Create seperate permission for adding field inheritance": "https://www.drupal.org/files/issues/2024-06-13/field_inheritance_permission.patch"
},
Expand Down
2 changes: 1 addition & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dd4e0d7

Please sign in to comment.