Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using MoreObjects of Guava. #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maurizio-lattuada
Copy link

Hi,
this is a pull request for your library.
I'm using not the "MoreObjects" of Guava (I updated its version to the latest available, that is 19.0).
I also bumped up some other libraries.

@maurizio-lattuada
Copy link
Author

I bumped the JDK source and target to 1.7.
Feel free to review this pull request (loading "com.google.common.base.MoreObjects" instead of "com.google.common.base.Objects") and, if ok, to integrate it in the master.
Thank you for your time

@danielwegener
Copy link
Owner

Hi @maurizio-lattuada. To be honest, I do not really feel like I am having the time to maintain this old gem. I can accept and release this PR but I'd rather feel better if someone would is really using this lib would take it over. Are you interested? :)

@maurizio-lattuada
Copy link
Author

Hi Daniel,

I'm trying to "readapt" it to be used internally in our repository, just to
avoid to "bother" you :)
Believe me, when I try to change only the groupId and the artifactId of you
project to other values, then basically jaxb fucks-up claiming "no such
JAXB option: -Xguava". Really, no clue why...

If you have some ideas, we can avoid other effort on your side ;)

2016-11-11 15:39 GMT+01:00 Daniel Wegener [email protected]:

Hi @maurizio-lattuada https://github.com/maurizio-lattuada. To be
honest, I do not really feel like I am having the time to maintain this old
gem. I can accept and release this PR but I'd rather feel better if someone
would is really using this lib would take it over. Are you interested? :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATrwU7B0jYFXEdkxqC7roxPqGILFkU7Lks5q9H4PgaJpZM4JUCWT
.

Maurizio Lattuada

@danielwegener
Copy link
Owner

Mhm. Could be because of some incompatible change in maven - maybe newer maven versions do not execute the xjb compiler plugins correctly. Haven't tried to build this repo myself for ages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants