Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4: guava dep removed, using java7 methods instead #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afdia
Copy link

@afdia afdia commented Oct 7, 2016

Hi

(beforehand: I don't have the time at the moment to fork and rename the project (is this even possible at github?) and setup all the stuff to push to maven central, therefore I'm sharing this solution as a pull request; perhaps you need the plugin again some time in the future :) )

This pull request is an alternative solution to #8 without increasing the Guava version (because it removes Guava altogether).
Java is updated from 6 to 7, but I guess this is OK.

This change implements the suggestions from #4 with minimal changes:

  • building equals using java.util.Objects.deepEquals(...)
  • building hashCode using java.util.Objects.hash(...)
  • building toString using string concatenation
    • it avoids Guava version conflicts (MoreObjects requires Guava 18) and is easy to read

I also added a merge method for the collections, to avoid code duplication.

@afdia afdia force-pushed the master branch 2 times, most recently from b4978d1 to 3a329e8 Compare October 7, 2016 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant