Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug intermittent testing failures #26

Merged
merged 30 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
20bec6b
Try making figure sizes smaller
nfahlgren May 8, 2024
1bff455
Increase setup delay
nfahlgren May 10, 2024
6e02752
Increase delay to 10s
nfahlgren May 10, 2024
8788098
Change screen resolution
nfahlgren May 10, 2024
f05f741
Update continuous-integration.yml
maliagehan May 15, 2024
df608d0
Update continuous-integration.yml
maliagehan May 15, 2024
d162ec9
Update continuous-integration.yml
maliagehan May 15, 2024
6340f0d
Update continuous-integration.yml
maliagehan May 15, 2024
74c778c
Update continuous-integration.yml
maliagehan May 15, 2024
d62b213
Update continuous-integration.yml
maliagehan May 15, 2024
d5afb93
Update continuous-integration.yml
maliagehan May 15, 2024
93640aa
Update continuous-integration.yml
maliagehan May 15, 2024
4dc2d78
Update continuous-integration.yml
maliagehan May 15, 2024
0cf7668
Update continuous-integration.yml
maliagehan May 15, 2024
f990912
Update continuous-integration.yml
maliagehan May 15, 2024
3afe91b
test
maliagehan May 15, 2024
cf8b3a4
Create test_annotate_points.py
maliagehan May 15, 2024
b1e1812
Create test_annotate_get_centroids.py
maliagehan May 15, 2024
ecfbc68
Create test_napari_open.py
maliagehan May 15, 2024
cb848b5
Create test_napari_classes.py
maliagehan May 15, 2024
9a0fa6e
Create test_napari_label_classes.py
maliagehan May 15, 2024
c23e57b
viwer close
maliagehan May 15, 2024
c6035cb
Update test_napari_label_classes.py
maliagehan May 15, 2024
4f3555a
Update test_napari_open.py
maliagehan May 15, 2024
dbb565f
Create test_napari_join_labels.py
maliagehan May 15, 2024
b170a9a
Delete test_napari_join_labels.py
maliagehan May 15, 2024
6070954
Create test_napari_join_labels.py
maliagehan May 15, 2024
272f082
line returns.
maliagehan May 15, 2024
3daac8b
Update continuous-integration.yml
maliagehan May 16, 2024
19129c4
Update continuous-integration.yml
maliagehan May 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends libyaml-dev libegl1-mesa libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-shape0 libxcb-cursor0 xserver-xephyr xvfb
sudo apt-get install --no-install-recommends libyaml-dev libegl1-mesa libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-xinerama0 libxcb-shape0 libxcb-cursor0 xserver-xephyr
python -m pip install --upgrade pip
pip install flake8 pytest pytest-cov pytest-qt pytest-xvfb ipython anyio
- name: Lint with flake8
Expand All @@ -48,8 +47,9 @@ jobs:
pip uninstall -y opencv-python
pip install opencv-python-headless
- name: Tests
uses: aganders3/headless-gui@v2
uses: aganders3/headless-gui@v2.2
with:
xvfb-screen-size: 1280x720x24
run: pytest --cov-report=xml --cov=./
- name: Upload coverage to Deepsource
uses: deepsourcelabs/test-coverage-action@master
Expand Down
18 changes: 9 additions & 9 deletions tests/test_annotate_points.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def test_points(test_data):
img = cv2.imread(test_data.small_rgb_img)

# initialize interactive tool
drawer_rgb = Points(img, figsize=(12, 6))
drawer_rgb = Points(img, figsize=(5, 5))

# simulate mouse clicks
# event 1, left click to add point
Expand Down Expand Up @@ -56,7 +56,7 @@ def test_points_print_coords(test_data, tmpdir):
img = cv2.imread(test_data.small_rgb_img)

# initialize interactive tool
drawer_rgb = Points(img, figsize=(12, 6))
drawer_rgb = Points(img, figsize=(5, 5))

# simulate mouse clicks
# event 1, left click to add point
Expand All @@ -82,7 +82,7 @@ def test_points_import_list(test_data):
# Read in a test image
img = cv2.imread(test_data.small_rgb_img)
# initialize interactive tool
drawer_rgb = Points(img, figsize=(12, 6), label="default")
drawer_rgb = Points(img, figsize=(5, 5), label="default")
totalpoints1 = [(158, 531), (361, 112), (500, 418), (269.25303806488864, 385.69839981447126),
(231.21964288863632, 445.995245825603), (293.37177646934134, 448.778177179963),
(240.49608073650273, 277.1640769944342), (279.4571196975417, 240.05832560296852),
Expand All @@ -98,7 +98,7 @@ def test_points_import_list_warn(test_data):
# Read in a test image
img = cv2.imread(test_data.small_rgb_img)
# initialize interactive tool
drawer_rgb = Points(img, figsize=(12, 6), label="default")
drawer_rgb = Points(img, figsize=(5, 5), label="default")
totalpoints1 = [(158, 531), (361, 112), (500, 418), (445.50535717435065, 138.94515306122452)]
drawer_rgb.import_list(coords=totalpoints1)

Expand All @@ -108,7 +108,7 @@ def test_points_import_list_warn(test_data):
def test_points_import_file(test_data):
"""Test for plantcv-annotate."""
img = cv2.imread(test_data.small_rgb_img)
counter = Points(img, figsize=(8, 6))
counter = Points(img, figsize=(5, 5))
file = test_data.pollen_coords
counter.import_file(file)

Expand All @@ -121,7 +121,7 @@ def test_points_view(test_data):
img = cv2.imread(test_data.small_rgb_img)

# initialize interactive tool
drawer_rgb = Points(img, figsize=(12, 6))
drawer_rgb = Points(img, figsize=(5, 5))

# simulate mouse clicks
# event 1, left click to add point
Expand All @@ -137,7 +137,7 @@ def test_points_view(test_data):
drawer_rgb.onclick(e2)
drawer_rgb.view(view_all=False)

assert str(drawer_rgb.fig) == "Figure(1200x600)"
assert str(drawer_rgb.fig) == "Figure(500x500)"


def test_points_view_warn(test_data):
Expand All @@ -146,7 +146,7 @@ def test_points_view_warn(test_data):
img = cv2.imread(test_data.small_rgb_img)

# initialize interactive tool, implied default label and "r" color
drawer_rgb = Points(img, figsize=(12, 6))
drawer_rgb = Points(img, figsize=(5, 5))

# simulate mouse clicks, event 1=left click to add point
e1 = matplotlib.backend_bases.MouseEvent(name="button_press_event", canvas=drawer_rgb.fig.canvas,
Expand All @@ -156,4 +156,4 @@ def test_points_view_warn(test_data):
drawer_rgb.onclick(e1)
drawer_rgb.view(label="new", color='r')

assert str(drawer_rgb.fig) == "Figure(1200x600)"
assert str(drawer_rgb.fig) == "Figure(500x500)"
1 change: 1 addition & 0 deletions tests/test_napari_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ def test_napari_classes(make_napari_viewer):
keys = napari_classes(viewer)

assert keys == ['total', 'test']
viewer.close()
4 changes: 4 additions & 0 deletions tests/test_napari_join_labels.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def test_napari_join_labels(test_data):
labeled, _ = napari_join_labels(img, viewer)

assert np.shape(labeled) == (576, 537)
viewer.close()


def test_napari_join_allclass(test_data):
Expand All @@ -34,6 +35,7 @@ def test_napari_join_allclass(test_data):
labeled, _ = napari_join_labels(img, viewer)

assert np.shape(labeled) == (576, 537)
viewer.close()


def test_napari_join_warn(test_data):
Expand All @@ -54,6 +56,7 @@ def test_napari_join_warn(test_data):
labeled, _ = napari_join_labels(img, viewer)

assert np.shape(labeled) == (576, 537)
viewer.close()


def test_napari_join_print(test_data, tmpdir):
Expand All @@ -77,3 +80,4 @@ def test_napari_join_print(test_data, tmpdir):
labeled, _ = napari_join_labels(img, viewer)

assert np.shape(labeled) == (576, 537)
viewer.close()
1 change: 1 addition & 0 deletions tests/test_napari_label_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ def test_napari_label_classes_gray(test_data):
face_color="red", size=1)

assert len(viewer.layers['background'].data) == 1
viewer.close()
3 changes: 3 additions & 0 deletions tests/test_napari_open.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def test_napari_open_rgb(test_data):
face_color="red", size=1)

assert len(viewer.layers['total'].data) == 2
viewer.close()


def test_napari_open_gray(test_data):
Expand All @@ -25,6 +26,7 @@ def test_napari_open_gray(test_data):
face_color="red", size=1)

assert len(viewer.layers['total'].data) == 2
viewer.close()


def test_napari_open_envi(test_data):
Expand All @@ -38,3 +40,4 @@ def test_napari_open_envi(test_data):
face_color="red", size=1)

assert len(viewer.layers['total'].data) == 2
viewer.close()