-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug intermittent testing failures #26
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
remove xvfb
saw something about specifically using python 3.10.12
seeing if the problem is consistently with 3.10
3.10 isn't the problem. getting same error on 3.11.
omg I broke github actions....
missing comma
add points tests
add centroid tests
napari open
napari classes
napari label classes
testing viewer close on napari classes
testing viewer close
add viewer.close() to napari.open
added napari join labels tests with viewer close
added tests back one by one and found that the napari functions need to have viewer.close() after each test (even though the showviewer=false) for tests to run right on github actions, even though they consistently work locally. |
remove some line returns for consistency.
remove verbose and delay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repo continuous integration changed to decrease image size. Also found that we needed to add viewer.close() to tests even though viewer does close locally with no error consistently. Additional small changes were also made that were probably originally unnecessary when we were trying to troubleshoot building the repo. Actions now consistently run. Huzzah
Describe your changes
Changes aimed at debugging the cause of intermittent test failures where pytest exits with null code.
Type of update
Is this a: Work in progress
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md