typing: Account for the fact that requests.HTTPError .response migth be None now

[yarikoptic]

No description provided.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b575ef5) 88.94% compared to head (f4a250f) 88.93%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.01%     
==========================================
  Files          76       76              
  Lines       10240    10240              
==========================================
- Hits         9108     9107       -1     
- Misses       1132     1133       +1     

Flag	Coverage Δ
unittests	88.93% <40.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
dandi/dandiapi.py	87.29% <ø> (ø)
dandi/files/bases.py	78.52% <100.00%> (ø)
dandi/files/zarr.py	89.37% <100.00%> (ø)
dandi/download.py	88.46% <0.00%> (ø)
dandi/dandiarchive.py	85.22% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yarikoptic]

hm, there might have been functionality effects from the proposed here changes since seems some new tests start to fail then... or may be it is coinciding with fresh fixes in dandi-archive which might relate (failing tests are here about moves and uploads)...

[yarikoptic]

if fresh run fails with anything but test_update_dandiset_from_doi in 3.10 and 3.11 -- it is caused by the changes here and should be addressed

edit: I fail to reproduce locally and fail to understand how the diff could lead to the fails... heh

[yarikoptic]

oh, I guess there is a deeper meaning of bool(response) to be True if it not errorneous or smth like that

(Pdb) p bool(e.response)
False
*(Pdb) p e.response
<Response [400]>

[yarikoptic]

ok, only coverage is "affected". proceeding with a release

[github-actions]

🚀 PR was released in 0.57.0 🚀