Add missing term in ETA calculation #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in missing -dt term so ETA counts down correctly :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 88.79% 88.81% +0.01%
==========================================
Files 76 76
Lines 10220 10238 +18
==========================================
+ Hits 9075 9093 +18
Misses 1145 1145
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
typing fails are all unrelated and to be fixed by |
|
Thank you @sneakers-the-rat ! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1339
Add in missing -dt term so ETA counts down correctly :)
to quote @NickleDave : "I have changed but one line, yet achieved enlightenment in the path I took to change it"
https://neuromatch.social/@nicholdav/111297136870307787
(davey nickles i hereby see your one line PR and raise you one line PR with 40 line test)