-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7/n][dagster-fivetran] Implement load_fivetran_asset_specs #25808
Conversation
FivetranWorkspaceData
to FivetranConnectorTableProps
method
#25797
to convert Fivetran content into AssetSpecs. Defaults to DagsterFivetranTranslator. | ||
|
||
Returns: | ||
List[AssetSpec]: The set of assets representing the Tableau content in the workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring's return type description references Tableau content, but this function returns Fivetran assets. The return description should read: List[AssetSpec]: The set of assets representing the Fivetran content in the workspace.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
0e257e0
to
e0fb1eb
Compare
2000f24
to
5a21d96
Compare
e0fb1eb
to
77756ae
Compare
5a21d96
to
1ae5e13
Compare
77756ae
to
de7c6f3
Compare
1ae5e13
to
7523673
Compare
de7c6f3
to
f12bbb7
Compare
7523673
to
84f264d
Compare
f12bbb7
to
0c52d6a
Compare
84f264d
to
a2570c9
Compare
0c52d6a
to
6126387
Compare
a2570c9
to
8b78091
Compare
to convert Fivetran content into AssetSpecs. Defaults to DagsterFivetranTranslator. | ||
|
||
Returns: | ||
List[AssetSpec]: The set of assets representing the Fivetran content in the workspace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - I added one in 14f49b7, more to come when I update the docs.
6126387
to
29e9aa6
Compare
8b78091
to
9622bd8
Compare
29e9aa6
to
5383b60
Compare
9622bd8
to
c8ec63b
Compare
5383b60
to
86853f1
Compare
c8ec63b
to
0923217
Compare
0923217
to
14f49b7
Compare
Summary & Motivation
This PR implements the
load_fivetran_asset_specs
function:How I Tested These Changes
Additional unit test
Changelog
[dagster-fivetran] The
load_fivetran_asset_specs
function is added. It can be used with theFivetranWorkspace
resource andDagsterFivetranTranslator
translator to load your Fivetran connector tables as external assets in Dagster.