[dagster-fivetran] Scaffold FivetranWorkspace for rework #25750
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on |
maximearmstrong
changed the title
maximearmstrong
force-pushed
the
maxime/rework-fivetran-1
branch
from
00edd81
to
8c291f8
Compare
| return {"content_type": self.content_type.value, "properties": self.properties} | ||
|
|
||
| @classmethod | ||
| def from_cached_data(cls, data: Mapping[Any, Any]) -> "FivetranContentData": |
There was a problem hiding this comment.
why is this one necessary? Feel like this class should just be @whitelist_for_serdes if we need to cache.
There was a problem hiding this comment.
Thanks for the feedback!
This was the original pattern for Power BI, but I see that it was updated to use @whitelist_for_serdes since then.
I based my pattern here on the Tableau integration, which was not updated to use @whitelist_for_serdes yet.
Changes for this PR made in 4dfe34d, I will also update Tableau in another PR.
|
|
||
| _client: FivetranClient = PrivateAttr(default=None) | ||
|
|
||
| def get_client(self) -> FivetranClient: |
There was a problem hiding this comment.
Curious what the motivation for separating out the client is here - just to separate out the workspace loading and the actual API interactions?
There was a problem hiding this comment.
Exactly - this is the current pattern for Tableau and Looker.
maximearmstrong
force-pushed
the
maxime/rework-fivetran-1
branch
from
8c291f8
to
4dfe34d
Compare
Summary & Motivation
Builds out a very barebones resource and client classes for the new version of the Fivetran integration.
How I Tested These Changes
Tests will be added in subsequent PRs.