Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.37 - link to changed assets for branch deployment #162

Closed
wants to merge 6 commits into from

Conversation

jamiedemaria
Copy link

@jamiedemaria jamiedemaria commented Apr 5, 2024

Adds a column to the branch deployment comment with a link to the changed assets for a particular PR.

You can see the comment in this PR! and here https://github.com/dagster-io/dagster-cloud-action-test/pull/38 but my test PR to update Purina isn't showing the new column https://github.com/dagster-io/internal/pull/9141 which is confusing and i need to investigate

Copy link

github-actions bot commented Apr 5, 2024

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Changed Assets Updated
from_gh_action View in Cloud View Changed Assets Apr 05, 2024 at 05:48 PM (UTC)

@@ -114,7 +114,7 @@ def update_dagster_cloud_pex(
"-o=dagster-cloud.pex",
"--platform=manylinux2014_x86_64-cp-38-cp38",
"--platform=macosx_12_0_x86_64-cp-38-cp38",
"--platform=macosx_12_0_arm64-cp-38-cp38",
# "--platform=macosx_12_0_arm64-cp-38-cp38",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

@jamiedemaria
Copy link
Author

need to restart this PR from scratch since other releases have gone out. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant