Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.37 - link to changed assets for branch deployment #162

Closed
wants to merge 6 commits into from
Closed

Release 0.1.37 - link to changed assets for branch deployment #162

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
807f698
add link
jamiedemaria Mar 29, 2024
547b2d3
dont do arm build
jamiedemaria Mar 29, 2024
b83af37
rebild
jamiedemaria Mar 29, 2024
dace86a
update title and link
jamiedemaria Apr 5, 2024
9d0d2db
rebuild
jamiedemaria Apr 5, 2024
4faf6f1
pex file
jamiedemaria Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/utils/copy_template/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "A string of the base image name for the deployed code location image."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/copy_template.sh"
2 changes: 1 addition & 1 deletion actions/utils/deploy/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ outputs:
description: "The Cloud deployment associated with this branch."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/deploy.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/get_branch_deployment/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ outputs:
description: "The Cloud deployment associated with this branch."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/get_branch_deployment.sh"
2 changes: 1 addition & 1 deletion actions/utils/notify/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ inputs:

runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/notify.sh"
args:
- ${{ inputs.pr }}
2 changes: 1 addition & 1 deletion actions/utils/registry_info/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ inputs:
description: "Alternative to providing organization ID. The URL of your Dagster Cloud organization."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/registry_info.sh"
2 changes: 1 addition & 1 deletion actions/utils/run/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ outputs:
description: "The ID of the launched run."
runs:
using: "docker"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.31"
image: "docker://ghcr.io/dagster-io/dagster-cloud-action:0.1.37"
entrypoint: "/run.sh"
args:
- ${{ inputs.pr }}
Binary file modified generated/gha/dagster-cloud.pex
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions gitlab/dbt/serverless-ci-dbt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ deploy-branch:
stage: deploy
rules:
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
# first create the branch deployment
- export PR_TIMESTAMP=$(git log -1 --format='%cd' --date=unix)
Expand Down Expand Up @@ -49,7 +49,7 @@ deploy-branch:

close_branch:
stage: deploy
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
when: manual
only:
- merge_requests
Expand All @@ -74,7 +74,7 @@ deploy:
stage: deploy
rules:
- if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
# install dbt package
- pip install pip --upgrade
Expand Down
8 changes: 4 additions & 4 deletions gitlab/hybrid-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ workflow:

initialize:
stage: setup
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- export
- dagster-cloud ci check --project-dir=$DAGSTER_PROJECT_DIR --dagster-cloud-yaml-path=$DAGSTER_CLOUD_YAML_PATH
Expand Down Expand Up @@ -75,7 +75,7 @@ deploy-docker:
dependencies:
- build-image
- initialize
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- dagster-cloud ci set-build-output --image-tag=$IMAGE_TAG
- dagster-cloud ci deploy
Expand All @@ -87,7 +87,7 @@ deploy-docker-branch:
dependencies:
- build-image
- initialize
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- dagster-cloud ci set-build-output --image-tag=$IMAGE_TAG
- dagster-cloud ci deploy
Expand All @@ -97,7 +97,7 @@ deploy-docker-branch:

close-branch:
stage: deploy
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
when: manual
only:
- merge_requests
Expand Down
6 changes: 3 additions & 3 deletions gitlab/serverless-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ deploy-branch:
stage: deploy
rules:
- if: $CI_PIPELINE_SOURCE == 'merge_request_event'
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
# first create the branch deployment
- export PR_TIMESTAMP=$(git log -1 --format='%cd' --date=unix)
Expand Down Expand Up @@ -35,7 +35,7 @@ deploy-branch:

close_branch:
stage: deploy
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
when: manual
only:
- merge_requests
Expand All @@ -60,6 +60,6 @@ deploy:
stage: deploy
rules:
- if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- /gitlab_action/deploy.py ./dagster_cloud.yaml
10 changes: 5 additions & 5 deletions gitlab/serverless-legacy-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ workflow:

parse-workspace:
stage: setup
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- python /gitlab_action/parse_workspace.py dagster_cloud.yaml >> build.env
- cp /Dockerfile.template .
Expand All @@ -23,7 +23,7 @@ parse-workspace:

fetch-registry-info:
stage: setup
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script: dagster-cloud serverless registry-info --url $DAGSTER_CLOUD_URL/prod --api-token $DAGSTER_CLOUD_API_TOKEN | grep '=' >> registry.env
artifacts:
reports:
Expand Down Expand Up @@ -53,7 +53,7 @@ deploy-docker:
- build-image
- parse-workspace
- fetch-registry-info
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- dagster-cloud workspace add-location
--url $DAGSTER_CLOUD_URL/prod
Expand All @@ -74,7 +74,7 @@ deploy-docker-branch:
- build-image
- parse-workspace
- fetch-registry-info
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
script:
- export PR_TIMESTAMP=$(git log -1 --format='%cd' --date=unix)
- export PR_MESSAGE=$(git log -1 --format='%s')
Expand Down Expand Up @@ -109,7 +109,7 @@ deploy-docker-branch:

close_branch:
stage: deploy
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.31
image: ghcr.io/dagster-io/dagster-cloud-action:0.1.37
when: manual
only:
- merge_requests
Expand Down
2 changes: 1 addition & 1 deletion scripts/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def update_dagster_cloud_pex(
"-o=dagster-cloud.pex",
"--platform=manylinux2014_x86_64-cp-38-cp38",
"--platform=macosx_12_0_x86_64-cp-38-cp38",
"--platform=macosx_12_0_arm64-cp-38-cp38",
# "--platform=macosx_12_0_arm64-cp-38-cp38",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

"--pip-version=23.0",
"--resolver-version=pip-2020-resolver",
"--venv=prepend",
Expand Down
10 changes: 7 additions & 3 deletions src/create_or_update_comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,19 @@ def main():
break

deployment_url = f"{org_url}/{deployment_name}/home"
changed_assets_url = f"{org_url}/{deployment_name}/asset-groups?changedInBranch=%5B%22CODE_VERSION%22%2C%22INPUTS%22%2C%22NEW%22%2C%22PARTITIONS_DEFINITION%22%5D"

message = f"[View in Cloud]({deployment_url})"
changed_assets_message = f"[View Changed Assets]({changed_assets_url})"
image_url = SUCCESS_IMAGE_URL

if action == "pending":
message = f"[Building...]({github_run_url})"
changed_assets_message = message
image_url = PENDING_IMAGE_URL
elif action == "failed":
message = f"[Deploy failed]({github_run_url})"
changed_assets_message = message
image_url = FAILED_IMAGE_URL

status_image = f'[<img src="{image_url}" width=25 height=25/>]({github_run_url})'
Expand All @@ -67,9 +71,9 @@ def main():
message = f"""
Your pull request is automatically being deployed to Dagster Cloud.

| Location | Status | Link | Updated |
| ----------------- | --------------- | ------- | --------------- |
| `{location_name}` | {status_image} | {message} | {time_str} |
| Location | Status | Link | Changed Assets | Updated |
| ----------------- | --------------- | --------- | ------------------------ | --------------- |
| `{location_name}` | {status_image} | {message} | {changed_assets_message} | {time_str} |
"""

if comment_to_update:
Expand Down
Loading