MUI V5 Migration #554
MUI V5 Migration #554
Conversation
Refactor imports: switch from material-ui/core to mui/material Update media queries to reflect MUI's new exclusivity behavior Fix to some breaking component features in Autocomplete, Skeleton, IconButton, Alert, etc. Update class selectors for styling in DETabs to account for specificity changes Wrap stories in ThemeProvider
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @material-ui/[email protected], @material-ui/[email protected], @material-ui/[email protected], @material-ui/[email protected] |
There was a problem hiding this comment.
Overall LGTM 👍 🎉 ✨
Thanks for tackling this migration. It looks like it turned out to be much more tedious than I anticipated 😩 Did you use any of their codemods for some of these migrations?
I had a couple of minor suggestions, and I did catch at least 1 bug, but otherwise 
when ready! 🎊
|
By the way, I noticed there were no chromatic tests for this PR. Maybe your GitHub action was disabled? Maybe see if you can turn it back on at https://github.com/sboleyn/cyverse-de-sonora/actions before pushing more commits? edit: Actually I just checked the logs for your chromatic actions (TIL), and there seems to be an issue with the |
There was a problem hiding this comment.
Sorry for the thrash in this PR, but after reviewing the latest Chromatic tests, and then testing all of these details drawers at different sizes with these latest changes, I now think my assumption about the original intention for these drawer sizes was incorrect.
Some of the breakpoints changes reverted in the last commit look fine, but I found some details drawers that we probably should revert again, and fix the up breakpoint size instead 😖
I'll leave it up to you if you wish to fix those breakpoints I commented on in this PR, or we can merge this PR as-is and fix them in a follow-up PR.
Probably broken by MUI v5 Autocomplete upgrade in cyverse-de#554
Probably broken by MUI v5 Autocomplete upgrade in cyverse-de#554
Probably broken by MUI v5 Autocomplete upgrade in cyverse-de#554
The majority of changes are relating to the MUI 5 migration and cover Breaking changes parts 1 and 2 of the migration documentation. A fix to a few random console errors were also wrapped into these changes.