CORE-1936 MUI v5 fixes #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons are now primary color by default, so dialog primary action buttons looked the same as "cancel" buttons.
The data selection drawer zIndex was less than the zIndex for dialogs in mui v5, so this fixes it so that it's no longer hidden behind data move or copy metadata dialogs. Also fixed a warning about an elevation with the outlined variant.
Sometimes when new analyses are launched and added to the "Recent Analyses" section of the dashboard, navigating away, then back to the dashboard displays an error: `A client-side exception has occurred` The browser dev console displays "Minified React error cyverse-de#310; visit https://reactjs.org/docs/error-decoder.html?invariant=310" Which translates to `Rendered more hooks than during the previous render`. A possible fix for this may have been added to the `InstantLaunchItem` in cyverse-de#312, so I'm attempting this fix in the remaining dashboard items.
|
I'm going to merge this now, but reviews are still welcome 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add some fixes for changes introduced by MUI v5 added in #554.
containedvariants, since theButtoncomponent now uses theprimarycolor by default, and most of our dialog primary action buttons now looked the same as "cancel" buttons. Thecontainedvariant should also help the primary action to stand out more.zIndextomodal.zIndexwas less than thezIndexfor dialogs in MUI v5, so it was hidden behind dialogs like the data move or copy metadata dialogs.This PR also includes some fixes not related to the MUI v5 upgrade, but are for bugs that I came across during testing; such as a
startingPathwarning in thePathListViewer, and aclient-side exception has occurrederror that can display after launching analyses and navigating away and then back to the dashboard.See visual changes in Chromatic.