Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill old connections when demoting primary #561

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Aug 29, 2023

This PR fixes failover failure.

When the network of a node that the Primary MySQL Pod runs on is unavailable, the MOCO executes a failover.
However, if the network of the node is restored during the failover,
failover gets stuck, and MySQLCluster will be unavailable for a long time.

Signed-off-by: Masayuki Ishii [email protected]

@masa213f masa213f self-assigned this Aug 29, 2023
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@masa213f masa213f changed the title Kill old connections when demoting previous primary Kill old connections when demoting primary Oct 20, 2023
Signed-off-by: Masayuki Ishii <[email protected]>
Signed-off-by: Masayuki Ishii <[email protected]>
@masa213f masa213f marked this pull request as ready for review October 20, 2023 07:06
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit b61bb8a into main Oct 23, 2023
14 checks passed
@ymmt2005 ymmt2005 deleted the fix-failover-fail branch October 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants