Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gomega matcher in Eventually and check pods' labels #584

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Oct 18, 2023

This PR makes the following changes to the envtest.

  1. Use Gomega matcher in Eventually block.
    It's just a refactoring.
  2. Check the pods' metadata in Eventually or Consistently blocks.
    The pods' metadata are updated asynchronously with MySQLCluster's .status.
    With the current implementation, pods's metadata are checked just once using Expect.
    Therefore, if there is a delay in updating the pods' metadata, the test may fail.
  3. Add more checks for pods's labels.
    Preparation for Kill old connections when demoting primary #561

Signed-off-by: Masayuki Ishii [email protected]

@masa213f masa213f self-assigned this Oct 18, 2023
Copy link
Member

@zoetrope zoetrope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit ee3134d into main Oct 19, 2023
14 checks passed
@masa213f masa213f deleted the fix-20231018 branch October 19, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants