Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SuperPoint_Open weights to be loaded from local cache #68

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

aduverger
Copy link
Contributor

Hello,
This PR addresses an issue we encounter when having to use SuperPoint in a production environment.
Currently, the pre-trained model weights MUST be downloaded from https://github.com/rpautrat/SuperPoint/raw/master/weights/superpoint_v6_from_tf.pth.

This is not compatible with a production env:

  • You don't necessarily want your model to access internet
  • GitHub could be down for a moment, thus your endpoint could be down as well
  • Rémi Pautrat could rename / delete that file, just to watch the world burn 😄

This PR allows the users to specify a weights parameter in the config input (similar to LightGlue), so that the weights are loaded from cache instead of from rpautrat's repo.

@aduverger
Copy link
Contributor Author

Anyone could have a look at this PR please :) ?
@sarlinpe, @Phil26AT, @rpautrat

@sarlinpe
Copy link
Member

sarlinpe commented Apr 2, 2024

Nice, thank you! And apologies for the late reply.

@sarlinpe sarlinpe enabled auto-merge (squash) April 2, 2024 08:57
@sarlinpe sarlinpe merged commit 1f56839 into cvg:main Apr 2, 2024
2 checks passed
@aduverger aduverger deleted the superpoint-cache branch April 3, 2024 14:05
tompritch30 pushed a commit to tompritch30/glue-factory that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants