-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CMake's fortran name mangling #51
Conversation
@amontoison It doesn't look like the PR is colliding with our efforts into Uno_jll, can you confirm? |
It seems to be fine. |
Thanks! |
After that #53 is merged, it will safe to merge any PR if CI builds passed. |
@amontoison for some reason, the current PR doesn't trigger
? |
Hello, The usual behaviour is that the triggers are governed by the "main" branch. I.e. if the main branch has a policy to trigger a build when a PR is opened then all PRs being opened will trigger a build. If a branch that is itself in a PR will be adding some new policy, then these new policies are not triggered up until they are policies of the master branch itself. The counter part is usually more important. So if you got annoyed by builds triggering every time you modify something and you want to mute them, then this doesn't actually remove the protection of the master branch up until this has been approved and merged. In the case on hand the uno master branch will be protected from accidentally braking the Julia interface from now on. |
Review should trigger julia-tests-ubuntu.yml
It's because @worc4021 needs to rebase this branch to include the last commits added in git remote add upstream https://github.com/cvanaret/Uno.git
git fetch upstream
git rebase upstream/main
git push -f |
It's a wrap! Thanks a lot @worc4021! |
This PR introduces applies CMake's FortranCInterface name mangling to allow other toolchains to compile uno. No change in functionality is expected.