Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake's fortran name mangling #51

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Use CMake's fortran name mangling #51

merged 3 commits into from
Oct 29, 2024

Conversation

worc4021
Copy link
Contributor

This PR introduces applies CMake's FortranCInterface name mangling to allow other toolchains to compile uno. No change in functionality is expected.

@cvanaret
Copy link
Owner

@amontoison It doesn't look like the PR is colliding with our efforts into Uno_jll, can you confirm?

@amontoison
Copy link
Contributor

amontoison commented Oct 28, 2024

It seems to be fine.
I should add a CI build here that generates a local Uno_jll.
I can quickly do that tomorrow.

@cvanaret
Copy link
Owner

It seems to be fine. I should add a CI build here that generates a local Uno_jll. I can quickly do that tomorrow.

Thanks!
It's probably related to #49?

@amontoison
Copy link
Contributor

After that #53 is merged, it will safe to merge any PR if CI builds passed.

cvanaret
cvanaret previously approved these changes Oct 29, 2024
@cvanaret
Copy link
Owner

@amontoison for some reason, the current PR doesn't trigger julia-tests-ubuntu.yml (probably because it was submitted before yours). Do we need to add a type in:

pull_request:
    types: [opened, synchronize, reopened]

?

@worc4021
Copy link
Contributor Author

Hello,

The usual behaviour is that the triggers are governed by the "main" branch. I.e. if the main branch has a policy to trigger a build when a PR is opened then all PRs being opened will trigger a build. If a branch that is itself in a PR will be adding some new policy, then these new policies are not triggered up until they are policies of the master branch itself. The counter part is usually more important. So if you got annoyed by builds triggering every time you modify something and you want to mute them, then this doesn't actually remove the protection of the master branch up until this has been approved and merged.

In the case on hand the uno master branch will be protected from accidentally braking the Julia interface from now on.

@cvanaret cvanaret dismissed their stale review October 29, 2024 10:58

Review should trigger julia-tests-ubuntu.yml

@amontoison
Copy link
Contributor

amontoison commented Oct 29, 2024

@amontoison for some reason, the current PR doesn't trigger julia-tests-ubuntu.yml (probably because it was submitted before yours). Do we need to add a type in:

pull_request:
    types: [opened, synchronize, reopened]

?

It's because @worc4021 needs to rebase this branch to include the last commits added in main.
You can do that with the following commands:

git remote add upstream https://github.com/cvanaret/Uno.git
git fetch upstream
git rebase upstream/main
git push -f

@cvanaret cvanaret merged commit d056351 into cvanaret:main Oct 29, 2024
3 checks passed
@cvanaret
Copy link
Owner

It's a wrap! Thanks a lot @worc4021!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants