Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia tests to GitHub actions #49

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

odow
Copy link
Contributor

@odow odow commented Oct 28, 2024

Closes #48
Closes #46

I don't think a third-party can add new GitHub action scripts and have them run, so @cvanaret probably needs to cherry-pick my commit into a branch on the cvanaret/Uno remote. I guess I have permission because I previously committed.

But we first need a way of compiling uno_ampl in CI.

unotest/runtests.jl Outdated Show resolved Hide resolved
@odow odow force-pushed the od/jltest branch 3 times, most recently from 123db4b to 0282ec5 Compare October 29, 2024 21:57
@odow odow marked this pull request as ready for review October 29, 2024 22:14
@odow odow changed the title WIP: Add Julia tests to GitHub actions Add Julia tests to GitHub actions Oct 29, 2024
@odow
Copy link
Contributor Author

odow commented Oct 29, 2024

Now we can test if things like #45 are actually fixed

@odow
Copy link
Contributor Author

odow commented Oct 30, 2024

I've marked this as closing #46 as well, since it isn't failing anymore. I don't know which commit was responsible.

@cvanaret
Copy link
Owner

I've marked this as closing #46 as well, since it isn't failing anymore. I don't know which commit was responsible.

Interesting. I've temporarily disabled function scaling, which seems to have solved the issue!

@cvanaret cvanaret merged commit 950c0fe into cvanaret:main Oct 30, 2024
3 checks passed
@cvanaret
Copy link
Owner

@odow thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and test uno_ampl in CI Failing MOI.Test.test_nonlinear_expression_hs109
2 participants