Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced std::optional.value() with * dereferencing #101

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Replaced std::optional.value() with * dereferencing #101

merged 1 commit into from
Nov 17, 2024

Conversation

cvanaret
Copy link
Owner

Replaced:

if (x.has_value()) {
   // use x.value()
}

with

if (x.has_value()) {
   // use *x
}

as not supported by macOS < 10.13.
Removed specialized CI code for macOS (not needed any more).

@cvanaret
Replaced std::optional.value() with * dereferencing + removed special…
a425f78 
…ized CI code for macOS (not needed any more)
@cvanaret cvanaret merged commit 154c59a into main Nov 17, 2024
3 checks passed
@cvanaret cvanaret deleted the fix_optional branch November 17, 2024 13:32
This was referenced Nov 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cvanaret