Tag v1.3.0 doesn't compile on macOS

[cvanaret]

Reason: std::optional::value() is not available on macOS < 10.14

[amontoison]

@cvanaret I found how to fix it by installing a SDK of macOS 10.15 but I have this new error now:

[10:13:49] In file included from /workspace/srcdir/Uno/uno/reformulation/ElasticVariables.cpp:4:
[10:13:49] In file included from /workspace/srcdir/Uno/uno/reformulation/ElasticVariables.hpp:7:
[10:13:49] /workspace/srcdir/Uno/uno/linear_algebra/SparseVector.hpp:64:27: error: implicit instantiation of undefined template 'std::vector<unsigned long>'
[10:13:49]    64 |       std::vector<size_t> indices{};
[10:13:49]       |                           ^
[10:13:49] /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/include/c++/v1/iosfwd:217:28: note: template is declared here
[10:13:49]   217 | class _LIBCPP_TEMPLATE_VIS vector;
[10:13:49]       |                            ^
[10:13:49] In file included from /workspace/srcdir/Uno/uno/reformulation/ElasticVariables.cpp:4:
[10:13:49] In file included from /workspace/srcdir/Uno/uno/reformulation/ElasticVariables.hpp:7:
[10:13:49] /workspace/srcdir/Uno/uno/linear_algebra/SparseVector.hpp:65:32: error: implicit instantiation of undefined template 'std::vector<unsigned long>'
[10:13:49]    65 |       std::vector<ElementType> values{};
[10:13:49]       |                                ^
[10:13:49] /workspace/srcdir/Uno/uno/reformulation/ElasticVariables.hpp:20:28: note: in instantiation of template class 'uno::SparseVector<unsigned long>' requested here
[10:13:49]    20 |       SparseVector<size_t> positive{};
[10:13:49]       |                            ^
[10:13:49] /opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/usr/include/c++/v1/iosfwd:217:28: note: template is declared here
[10:13:49]   217 | class _LIBCPP_TEMPLATE_VIS vector;
[10:13:49]       |                            ^
[10:13:49] 2 errors generated.

[cvanaret]

Missing include fixed in #98.

[amontoison]

@cvanaret
I can't debug the new release until monday but a quick solution that you can try is replace rm by mv at this
line:
https://github.com/cvanaret/Uno/blob/main/.github/julia/build_tarballs_release.jl#L101

It will put less presure on the hard drive and you can just rename System into System_old like this.

If it works, we can things like this and I don't to have a look next week 🤞

[cvanaret]

Same deal, unfortunately...

2024-11-16T23:44:24.2102182Z [23:44:24]  ---> mv /opt/${target}/${target}/sys-root/System /opt/${target}/${target}/sys-root/System_old
2024-11-16T23:44:24.9305679Z [23:44:24] mv: can't remove '/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/System/Library/Printers/Libraries': I/O error
2024-11-16T23:44:24.9312185Z [23:44:24] mv: can't remove '/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/System/Library/Frameworks/Tcl.framework/Versions/8.4/Headers/tcl-private': I/O error
2024-11-16T23:44:24.9317349Z [23:44:24] mv: can't remove '/opt/x86_64-apple-darwin14/x86_64-apple-darwin14/sys-root/System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers/tcl-private': I/O error
...

Not urgent though! We'll sort this out next week 👍

[cvanaret]

@amontoison Good news: I managed to create the release (but I cheated a bit)!
There's another way to dereference optional values. Instead of:

if (x.has_value()) {
   // use x.value()
}

which is not compatible with macOS < 10.14, you can write:

if (x.has_value()) {
   // use *x
}

So I made these changes (#101) and reverted your changes in generate_binaries.jl (#102) and the copying of the licenses. That works :)
It doesn't solve the mystery, but as long as we don't use std::optional.has_value(), we should be fine.
Thanks for your help!