Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add Support for input_number domain #61

Merged
merged 6 commits into from
Aug 16, 2023
Merged

[feat] Add Support for input_number domain #61

merged 6 commits into from
Aug 16, 2023

Commits on Aug 16, 2023

  1. initial controller for input-number domain

    @lizsugar @rohankapoorcom
    lizsugar authored and rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a014c06 View commit details
    Browse the repository at this point in the history

  2. Add input_number domain to slider-button-card 

    Outstanding bug: Rounding error when input_number step is set to certain values (observed easily with step set to 2 or 3)
    @lizsugar @rohankapoorcom
    lizsugar authored and rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    315295b View commit details
    Browse the repository at this point in the history

  3. cleanup

    @lizsugar @rohankapoorcom
    lizsugar authored and rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8bd2152 View commit details
    Browse the repository at this point in the history

  4. Resolve issue in custom-cards#3 where the functional step count was a… 

    … result of both

the step and the max of an input_number entity.

Appears that at this time applyStep() is unnecessary, and was in fact
causing the problem  I have tested stepped sliders of both input_number entities as well as
light and climate entities, and stepping still works as expected when
applyStep() is not called at all.

This does not resolve the issue where step count results in "illegal"
values on certain input_number entities.
    @lizsugar @rohankapoorcom
    lizsugar authored and rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5104562 View commit details
    Browse the repository at this point in the history

  5. disable debug

    @lizsugar @rohankapoorcom
    lizsugar authored and rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b94246c View commit details
    Browse the repository at this point in the history

  6. Update README for input_number support

    @rohankapoorcom
    rohankapoorcom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8e92000 View commit details
    Browse the repository at this point in the history